Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.h

Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: error tolerance for missing background page for key events. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl.h
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.h b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
index e6b6a0fe77d7f35afd936dc065d280d08c77d7b7..cdf40a34976d3de7fb13c1cb882d0ddd2d6d25e8 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.h
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.h
@@ -65,11 +65,11 @@ class InputMethodManagerImpl : public InputMethodManager,
virtual void ChangeInputMethod(const std::string& input_method_id) OVERRIDE;
virtual void ActivateInputMethodMenuItem(const std::string& key) OVERRIDE;
virtual void AddInputMethodExtension(
- Profile* profile,
- const std::string& id,
+ const std::string& extension_id,
+ const InputMethodDescriptors& descriptors,
InputMethodEngineInterface* instance) OVERRIDE;
- virtual void RemoveInputMethodExtension(Profile* profile,
- const std::string& id) OVERRIDE;
+ virtual void RemoveInputMethodExtension(
+ const std::string& extension_id) OVERRIDE;
virtual void GetInputMethodExtensions(
InputMethodDescriptors* result) OVERRIDE;
virtual void SetEnabledExtensionImes(std::vector<std::string>* ids) OVERRIDE;
@@ -156,12 +156,6 @@ class InputMethodManagerImpl : public InputMethodManager,
// (after list of enabled input methods has been updated)
void ReconfigureIMFramework();
- // Gets the current active user profile.
- // Note: this method is deprecated as ActiveUserProfile might change
- // during asynchronous operations that leads to strange crashes.
- // Use with caution!
- Profile* GetProfile() const;
-
scoped_ptr<InputMethodDelegate> delegate_;
// The current browser status.
@@ -210,12 +204,8 @@ class InputMethodManagerImpl : public InputMethodManager,
base::WeakPtrFactory<InputMethodManagerImpl> weak_ptr_factory_;
- // The engine map:
- // { Profile : { input_method_id : Engine } }.
- typedef std::map<std::string, InputMethodEngineInterface*>
- EngineMap;
- typedef std::map<Profile*, EngineMap, ProfileCompare> ProfileEngineMap;
- ProfileEngineMap profile_engine_map_;
+ // The engine map: { extension_id : { Engine } }.
Yuki 2014/08/06 04:42:24 { extension_id : Engine }, I think. Or, // The en
Shu Chen 2014/08/06 05:45:03 Done.
+ std::map<std::string, InputMethodEngineInterface*> engine_map_;
DISALLOW_COPY_AND_ASSIGN(InputMethodManagerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698