Chromium Code Reviews| Index: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc |
| diff --git a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc |
| index a5df161a632924fb0021140edc0454983cf553a5..68e7f07fc7789d78a974a6af16d73675fe2f6039 100644 |
| --- a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc |
| +++ b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc |
| @@ -175,15 +175,8 @@ class InputMethodEngineTest : public testing::Test { |
| engine_.reset(new InputMethodEngine()); |
| observer_ = new TestObserver(); |
| scoped_ptr<InputMethodEngineInterface::Observer> observer_ptr(observer_); |
| - engine_->Initialize(NULL /* profile */, |
| - observer_ptr.Pass(), |
| - "", |
| - whitelisted ? kTestExtensionId : kTestExtensionId2, |
| - kTestImeEngineId, |
| - languages_, |
| - layouts_, |
| - options_page_, |
| - input_view_); |
| + engine_->Initialize(observer_ptr.Pass(), |
| + whitelisted ? kTestExtensionId : kTestExtensionId2); |
| } |
| void FocusIn(ui::TextInputType input_type) { |
| @@ -218,19 +211,19 @@ TEST_F(InputMethodEngineTest, TestSwitching) { |
| // Enable/disable with focus. |
| FocusIn(ui::TEXT_INPUT_TYPE_URL); |
| EXPECT_EQ(NONE, observer_->GetCallsBitmapAndReset()); |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
|
Yuki
2014/08/06 04:42:23
s/Engine/Component/
Shu Chen
2014/08/06 05:45:03
Done.
|
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->Disable(); |
| EXPECT_EQ(DEACTIVATED, observer_->GetCallsBitmapAndReset()); |
| // Enable/disable without focus. |
| engine_->FocusOut(); |
| EXPECT_EQ(NONE, observer_->GetCallsBitmapAndReset()); |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->Disable(); |
| EXPECT_EQ(DEACTIVATED, observer_->GetCallsBitmapAndReset()); |
| // Focus change when enabled. |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->FocusOut(); |
| EXPECT_EQ(ONBLUR, observer_->GetCallsBitmapAndReset()); |
| @@ -248,12 +241,12 @@ TEST_F(InputMethodEngineTest, TestSwitching_Password_3rd_Party) { |
| // Enable/disable with focus. |
| FocusIn(ui::TEXT_INPUT_TYPE_PASSWORD); |
| EXPECT_EQ(NONE, observer_->GetCallsBitmapAndReset()); |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->Disable(); |
| EXPECT_EQ(DEACTIVATED, observer_->GetCallsBitmapAndReset()); |
| // Focus change when enabled. |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->FocusOut(); |
| EXPECT_EQ(ONBLUR, observer_->GetCallsBitmapAndReset()); |
| @@ -268,12 +261,12 @@ TEST_F(InputMethodEngineTest, TestSwitching_Password_Whitelisted) { |
| // Enable/disable with focus. |
| FocusIn(ui::TEXT_INPUT_TYPE_PASSWORD); |
| EXPECT_EQ(NONE, observer_->GetCallsBitmapAndReset()); |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->Disable(); |
| EXPECT_EQ(DEACTIVATED, observer_->GetCallsBitmapAndReset()); |
| // Focus change when enabled. |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| EXPECT_EQ(ACTIVATE | ONFOCUS, observer_->GetCallsBitmapAndReset()); |
| engine_->FocusOut(); |
| EXPECT_EQ(ONBLUR, observer_->GetCallsBitmapAndReset()); |
| @@ -286,7 +279,7 @@ TEST_F(InputMethodEngineTest, TestSwitching_Password_Whitelisted) { |
| TEST_F(InputMethodEngineTest, TestHistograms) { |
| CreateEngine(true); |
| FocusIn(ui::TEXT_INPUT_TYPE_TEXT); |
| - engine_->Enable(); |
| + engine_->Enable(kTestImeEngineId); |
| std::string error; |
| ExpectNewSample("InputMethod.Enable.test_engine_id", 1, 1, 1); |
| engine_->CommitText(1, "input", &error); |