Split onc::IsRecommendedValue into onc_utils.cc

Split onc::IsRecommendedValue into onc_utils.cc

Separate out the Recommended parsing from NetworkPropertyUIData so that
it can be used independently.

BUG=279351
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287375

[pneubeck (no reviews), 2014-08-04 10:14:30]

lgtm with comments.

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/network_property_ui_data.cc (right):

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR) <<
"ONC dictionary recommends key but has no value: "
This is not an error, it means that the default value (of ChromeOS/Shill) should
be used.
info/vlog would be fine.

https://codereview.chromium.org/433143002/diff/20001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_utils.cc (right):

https://codereview.chromium.org/433143002/diff/20001/chromeos/network/onc/onc...
chromeos/network/onc/onc_utils.cc:675: bool IsRecommendedValue(const
base::DictionaryValue* onc,
nit: Since |onc| is expected to be not null, this could be a reference.

https://codereview.chromium.org/433143002/diff/20001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_utils.h (right):

https://codereview.chromium.org/433143002/diff/20001/chromeos/network/onc/onc...
chromeos/network/onc/onc_utils.h:133: // Returns true if |property_key| is a
recommended value in the ONC dictionary.
This should also mention that |property_key| is actually a '.' separated
sequence/path of ONC keys.

[stevenjb, 2014-08-04 15:12:32]

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/network_property_ui_data.cc (right):

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR) <<
"ONC dictionary recommends key but has no value: "
On 2014/08/04 10:14:30, pneubeck wrote:
> This is not an error, it means that the default value (of ChromeOS/Shill)
should
> be used.
> info/vlog would be fine.

Could you explain that a bit more? Why would a property be listed as Recommended
without a recommended value?

[pneubeck (no reviews), 2014-08-04 15:17:49]

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/options/network_property_ui_data.cc (right):

https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR) <<
"ONC dictionary recommends key but has no value: "
On 2014/08/04 15:12:32, stevenjb wrote:
> On 2014/08/04 10:14:30, pneubeck wrote:
> > This is not an error, it means that the default value (of ChromeOS/Shill)
> should
> > be used.
> > info/vlog would be fine.
> 
> Could you explain that a bit more? Why would a property be listed as
Recommended
> without a recommended value?

For example username, should be editable but there might not be a reasonable
default because the policy is applied to a whole organizational unit (OU).

[stevenjb, 2014-08-04 15:36:01]

On 2014/08/04 15:17:49, pneubeck wrote:
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> File chrome/browser/chromeos/options/network_property_ui_data.cc (right):
> 
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR) <<
> "ONC dictionary recommends key but has no value: "
> On 2014/08/04 15:12:32, stevenjb wrote:
> > On 2014/08/04 10:14:30, pneubeck wrote:
> > > This is not an error, it means that the default value (of ChromeOS/Shill)
> > should
> > > be used.
> > > info/vlog would be fine.
> > 
> > Could you explain that a bit more? Why would a property be listed as
> Recommended
> > without a recommended value?
> 
> For example username, should be editable but there might not be a reasonable
> default because the policy is applied to a whole organizational unit (OU).

So, why then would it have a 'Recommend' entry? Maybe an example ONC file would
help clarify? I'm fine with making this aVLOG, just trying to get up to speed on
all this.

[pneubeck (no reviews), 2014-08-04 15:38:32]

On 2014/08/04 15:36:01, stevenjb wrote:
> On 2014/08/04 15:17:49, pneubeck wrote:
> >
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> > File chrome/browser/chromeos/options/network_property_ui_data.cc (right):
> > 
> >
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> > chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR)
<<
> > "ONC dictionary recommends key but has no value: "
> > On 2014/08/04 15:12:32, stevenjb wrote:
> > > On 2014/08/04 10:14:30, pneubeck wrote:
> > > > This is not an error, it means that the default value (of
ChromeOS/Shill)
> > > should
> > > > be used.
> > > > info/vlog would be fine.
> > > 
> > > Could you explain that a bit more? Why would a property be listed as
> > Recommended
> > > without a recommended value?
> > 
> > For example username, should be editable but there might not be a reasonable
> > default because the policy is applied to a whole organizational unit (OU).
> 
> So, why then would it have a 'Recommend' entry?
So that it is editable. If there is no recommend entry then the property is not
editable even if no value (e.g. username) is given.

> Maybe an example ONC file would
> help clarify? 
the existing original doc for this is go/onc-enterprise. but it's rather
lengthy.

> I'm fine with making this aVLOG, just trying to get up to speed on
> all this.

[stevenjb, 2014-08-04 16:46:57]

On 2014/08/04 15:38:32, pneubeck wrote:
> On 2014/08/04 15:36:01, stevenjb wrote:
> > On 2014/08/04 15:17:49, pneubeck wrote:
> > >
> >
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> > > File chrome/browser/chromeos/options/network_property_ui_data.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/433143002/diff/20001/chrome/browser/chromeos/...
> > > chrome/browser/chromeos/options/network_property_ui_data.cc:41: LOG(ERROR)
> <<
> > > "ONC dictionary recommends key but has no value: "
> > > On 2014/08/04 15:12:32, stevenjb wrote:
> > > > On 2014/08/04 10:14:30, pneubeck wrote:
> > > > > This is not an error, it means that the default value (of
> ChromeOS/Shill)
> > > > should
> > > > > be used.
> > > > > info/vlog would be fine.
> > > > 
> > > > Could you explain that a bit more? Why would a property be listed as
> > > Recommended
> > > > without a recommended value?
> > > 
> > > For example username, should be editable but there might not be a
reasonable
> > > default because the policy is applied to a whole organizational unit (OU).
> > 
> > So, why then would it have a 'Recommend' entry?
> So that it is editable. If there is no recommend entry then the property is
not
> editable even if no value (e.g. username) is given.
> 

Huh, OK. That seems unintuitive to me but I will update the doc and the code
accordingly.

[stevenjb, 2014-08-04 17:15:03]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-08-04 17:16:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/433143002/40001

[commit-bot: I haz the power, 2014-08-04 18:31:04]

Change committed as 287375