Split onc::IsRecommendedValue into onc_utils.cc

chromeos/network/onc/onc_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_utils.h"
 
 #include "base/base64.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
@@ skipping 654 matching lines @@
   if (type == ::onc::network_type::kWiFi)
     return NetworkTypePattern::WiFi();
   if (type == ::onc::network_type::kWimax)
     return NetworkTypePattern::Wimax();
   if (type == ::onc::network_type::kWireless)
     return NetworkTypePattern::Wireless();
   NOTREACHED();
   return NetworkTypePattern::Default();
 }
 
+bool IsRecommendedValue(const base::DictionaryValue* onc,

[pneubeck (no reviews), 2014/08/04 10:14:30]

nit: Since |onc| is expected to be not null, this could be a reference.

+                        const std::string& property_key) {
+  std::string property_basename, recommended_property_key;
+  size_t pos = property_key.find_last_of('.');
+  if (pos != std::string::npos) {
+    // 'WiFi.AutoConnect' -> 'AutoConnect', 'WiFi.Recommended'
+    property_basename = property_key.substr(pos + 1);
+    recommended_property_key =
+        property_key.substr(0, pos + 1) + ::onc::kRecommended;
+  } else {
+    // 'Name' -> 'Name', 'Recommended'
+    property_basename = property_key;
+    recommended_property_key = ::onc::kRecommended;
+  }
+
+  const base::ListValue* recommended_keys = NULL;
+  return (onc->GetList(recommended_property_key, &recommended_keys) &&
+          recommended_keys->Find(base::StringValue(property_basename)) !=
+          recommended_keys->end());
+}
+
 }  // namespace onc
 }  // namespace chromeos