Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 432863003: Add a DCHECK for NULL frame pointers in PasswordAutofillAgent (Closed)

Created:
6 years, 4 months ago by vabr (Chromium)
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add a DCHECK for NULL frame pointers in PasswordAutofillAgent This is to help investigating a clusterfuzz crash, but should stay permanently to document the expectations. BUG=399215 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287163

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vabr (Chromium)
Hi Ilya, PTAL. If you approve of this, please feel free to send it to ...
6 years, 4 months ago (2014-08-01 17:59:37 UTC) #1
Ilya Sherman
LGTM, though keep in mind that DCHECKs don't run in release builds, so I'm not ...
6 years, 4 months ago (2014-08-01 18:42:39 UTC) #2
vabr (Chromium)
Thanks, Ilya. I'm fine with the debug-only check, because the clusterfuzz runs both flavours, and ...
6 years, 4 months ago (2014-08-01 19:10:13 UTC) #3
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 4 months ago (2014-08-01 19:10:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/432863003/20001
6 years, 4 months ago (2014-08-01 19:15:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 06:05:10 UTC) #6
Message was sent while issue was closed. 
Change committed as 287163

Powered by Google App Engine
This is Rietveld 408576698