components/autofill/content/renderer/password_autofill_agent.cc - Issue 432863003: Add a DCHECK for NULL frame pointers in PasswordAutofillAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 432863003: Add a DCHECK for NULL frame pointers in PasswordAutofillAgent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unnecessary DCHECK Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index d23bbf1242dfed1c24e2b018cfc50db8a070bba8..fd52df402f4af45b7093dd304339c83e79794f98 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -1109,6 +1109,7 @@ void PasswordAutofillAgent::ProvisionallySavePassword(

blink::WebLocalFrame* frame,

const blink::WebFormElement& form,

ProvisionallySaveRestriction restriction) {

+ DCHECK(frame);

scoped_ptr<PasswordForm> password_form(CreatePasswordForm(form));

if (!password_form || (restriction == RESTRICTION_NON_EMPTY_PASSWORD &&

password_form->password_value.empty() &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »