Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 432773002: Add the named color `rebeccapurple` (#639) (Closed)

Created:
6 years, 4 months ago by mathias
Modified:
6 years, 4 months ago
Reviewers:
mathiasb, esprehn
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Project:
blink
Visibility:
Public.

Description

Add the named color `rebeccapurple` (#639) http://dev.w3.org/csswg/css-color-4/#valuedef-rebeccapurple Contributed by Mathias Bynens <mathiasb@opera.com>;. BUG=384254 TBR=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M LayoutTests/fast/css/named-colors.html View 3 chunks +5 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/named-colors-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/SVGCSSValueKeywords.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/common/Color.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/ColorData.gperf View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mathiasb
This is https://codereview.chromium.org/330243002 (already LGTM’d) re-uploaded with the correct base URL.
6 years, 4 months ago (2014-07-31 13:04:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathias@qiwi.be/432773002/1
6 years, 4 months ago (2014-07-31 13:05:45 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 13:05:46 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 13:05:47 UTC) #4
esprehn
Lgtm
6 years, 4 months ago (2014-07-31 14:17:39 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 4 months ago (2014-07-31 14:17:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathias@qiwi.be/432773002/1
6 years, 4 months ago (2014-07-31 14:18:07 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-31 15:43:31 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 16:50:08 UTC) #9
Message was sent while issue was closed.
Change committed as 179321

Powered by Google App Engine
This is Rietveld 408576698