Add the named color `rebeccapurple` (#639)

Add the named color `rebeccapurple` (#639)

http://dev.w3.org/csswg/css-color-4/#valuedef-rebeccapurple

Contributed by Mathias Bynens <mathiasb@opera.com>;.

BUG=384254

[esprehn, 2014-06-21 00:45:08]

lgtm, what is LOG=Y though?

[esprehn, 2014-06-21 00:45:40]

Also can you link to the spec change, or an email thread that added this in the
patch description? I know why this was added, but the patch description should
say why. :)

[pfeldman, 2014-06-21 04:53:38]

Changes to cm/ should go upstream (cm is codemirror) and then rolled into Blink.

[mathiasb, 2014-06-21 16:02:25]

On 2014/06/21 00:45:08, esprehn wrote:
> lgtm, what is LOG=Y though?

Ah, that’s a V8-only thing. I’ll remove it.

On 2014/06/21 00:45:40, esprehn wrote:
> Also can you link to the spec change, or an email thread that added this in
the
> patch description? I know why this was added, but the patch description should
> say why. :)

I’ll add a link to
http://lists.w3.org/Archives/Public/www-style/2014Jun/0312.html. The spec
(http://dev.w3.org/csswg/css-color/#named-colors) hasn’t been updated yet at the
time of writing.

On 2014/06/21 04:53:38, pfeldman wrote:
> Changes to cm/ should go upstream (cm is codemirror) and then rolled into
Blink.

Upstream patch: https://github.com/marijnh/CodeMirror/pull/2651

[TabAtkins, 2014-06-23 00:09:47]

On 2014/06/21 16:02:25, mathiasb wrote:
> I’ll add a link to
> http://lists.w3.org/Archives/Public/www-style/2014Jun/0312.html. The spec
> (http://dev.w3.org/csswg/css-color/#named-colors) hasn’t been updated yet at
the
> time of writing.

Spec was updated an hour or two after this comment:
http://dev.w3.org/csswg/css-color/#valuedef-rebeccapurple

[mathiasb, 2014-06-23 07:51:33]

On 2014/06/23 00:09:47, TabAtkins wrote:
> On 2014/06/21 16:02:25, mathiasb wrote:
> > I’ll add a link to
> > http://lists.w3.org/Archives/Public/www-style/2014Jun/0312.html. The spec
> > (http://dev.w3.org/csswg/css-color/#named-colors) hasn’t been updated yet at
> the
> > time of writing.
> 
> Spec was updated an hour or two after this comment:
> http://dev.w3.org/csswg/css-color/#valuedef-rebeccapurple

Yeah, I’ve since updated the patch description to include the link. Thanks!

[mathiasb, 2014-06-23 16:26:52]

On 2014/06/21 16:02:25, mathiasb wrote:
> On 2014/06/21 04:53:38, pfeldman wrote:
> > Changes to cm/ should go upstream (cm is codemirror) and then rolled into
> Blink.
> 
> Upstream patch: https://github.com/marijnh/CodeMirror/pull/2651

The upstream CodeMirror patch has now been merged:
https://github.com/marijnh/CodeMirror/commit/a1d1c4a3d373dbcc60b40ede2dc9ff65...
This addition is part of the CodeMirror v4.3.0 release.

[pfeldman, 2014-06-24 20:38:53]

devtools lgtm. please don't land the cm/ bit, we'll roll it in a separate
change.

[mathiasb, 2014-06-25 07:42:18]

On 2014/06/24 20:38:53, pfeldman wrote:
> devtools lgtm. please don't land the cm/ bit, we'll roll it in a separate
> change.

Updated the patch so it doesn’t touch `Source/devtools/front_end/cm/css.js`.

[lushnikov, 2014-06-25 13:21:11]

On 2014/06/25 07:42:18, mathiasb wrote:
> On 2014/06/24 20:38:53, pfeldman wrote:
> > devtools lgtm. please don't land the cm/ bit, we'll roll it in a separate
> > change.
> 
> Updated the patch so it doesn’t touch `Source/devtools/front_end/cm/css.js`.

Thank you. CodeMirror roll is in a CQ
https://codereview.chromium.org/354833004

[mathiasb, 2014-06-26 11:37:56]

On 2014/06/25 at 13:21:11, lushnikov wrote:
> Thank you. CodeMirror roll is in a CQ
> https://codereview.chromium.org/354833004

The CodeMirror roll is now committed:
https://src.chromium.org/viewvc/blink?revision=176976&view=revision

[mathiasb, 2014-07-04 11:32:47]

The CQ bit was checked by mathiasb@opera.com

[mathiasb, 2014-07-04 11:33:06]

The CQ bit was unchecked by mathiasb@opera.com

[esprehn, 2014-07-06 09:15:56]

Is this ready to land?

[mathiasb, 2014-07-06 09:24:38]

On 2014/07/06 at 09:15:56, esprehn wrote:
> Is this ready to land?

(I believe so.)

[esprehn, 2014-07-14 08:46:04]

lgtm

[esprehn, 2014-07-14 08:46:10]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-07-14 08:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-14 08:50:49]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[mathiasb, 2014-07-31 13:15:58]

On 2014/07/14 at 08:50:49, commit-bot wrote:
> Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

Re-uploaded with correct base URL here:
https://codereview.chromium.org/432773002/

[esprehn, 2014-08-01 13:46:08]

On 2014/07/31 at 13:15:58, mathiasb wrote:
> On 2014/07/14 at 08:50:49, commit-bot wrote:
> > Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.
> 
> Re-uploaded with correct base URL here:
https://codereview.chromium.org/432773002/

Closing this since that landed.