Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 432753003: DevTools: Fix url assignment when renaming files in workspace (Closed)

Created:
6 years, 4 months ago by vsevik
Modified:
6 years, 4 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix url assignment when renaming files in workspace BUG=398843 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179312

Patch Set 1 #

Patch Set 2 : Added a test and fixed correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/workspace-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/file-system-project-mapping-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/FileSystemWorkspaceBinding.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vsevik
PTAL
6 years, 4 months ago (2014-07-31 11:07:51 UTC) #1
lushnikov
lgtm
6 years, 4 months ago (2014-07-31 11:11:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/432753003/1
6 years, 4 months ago (2014-07-31 11:11:44 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-31 12:17:46 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-07-31 12:25:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/432753003/20001
6 years, 4 months ago (2014-07-31 12:26:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-31 13:52:00 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 14:31:19 UTC) #8
Message was sent while issue was closed. 
Change committed as 179312

Powered by Google App Engine
This is Rietveld 408576698