Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 43273004: Allow redirecting disassembly and deoptimization traces into a file. (Closed)

Created:
7 years, 1 month ago by Vyacheslav Egorov (Chromium)
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Allow redirecting disassembly and deoptimization traces into a file. This is controlled by two flags: --redirect_code_traces --redirect_code_traces_to=<filename> When redirection is enabled but --redirect_code_traces_to is not specified traces are written to a file code-<pid>-<isolate>.asm. This mangling scheme matches hydrogen.cfg and allows easy discovery of compilation artifacts in a multi-V8 environment (e.g. when compilation is traced from inside Chromium). D8 defines --redirect_code_traces_to=code.asm similar to hydrogen.cfg redirection. BUG= R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -216 lines) Patch
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/codegen.cc View 2 chunks +18 lines, -11 lines 0 comments Download
M src/d8.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 74 chunks +278 lines, -178 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.h View 4 chunks +70 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/safepoint-table.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/safepoint-table.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
This is the first CL among those that I mentioned. Please take a look.
7 years, 1 month ago (2013-10-25 16:13:25 UTC) #1
danno
lgtm
7 years, 1 month ago (2013-11-06 14:10:49 UTC) #2
Vyacheslav Egorov (Chromium)
7 years, 1 month ago (2013-11-07 16:35:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698