src/builtins.cc - Issue 43273004: Allow redirecting disassembly and deoptimization traces into a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 43273004: Allow redirecting disassembly and deoptimization traces into a file. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index b614904c9f468ba08708c8a3bb96710598415ab2..758967ec08d875ce5ccab732d4d120366e6a5079 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -1750,9 +1750,10 @@ void Builtins::SetUp(Isolate* isolate, bool create_heap_objects) {

builtins_[i] = code;

#ifdef ENABLE_DISASSEMBLER

if (FLAG_print_builtin_code) {

- PrintF("Builtin: %s\n", functions[i].s_name);

- Code::cast(code)->Disassemble(functions[i].s_name);

- PrintF("\n");

+ CodeTracer::Scope trace_scope(isolate->GetCodeTracer());

+ PrintF(trace_scope.file(), "Builtin: %s\n", functions[i].s_name);

+ Code::cast(code)->Disassemble(functions[i].s_name, trace_scope.file());

+ PrintF(trace_scope.file(), "\n");

}

#endif

} else {

« no previous file with comments | « src/assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »