Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 432473002: Reenable trace_event_unittest for windows (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
dsinclair, jam
CC:
chromium-reviews, wfh+watch_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reenable trace_event_unittest for windows BUG=396403 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287690

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M base/debug/trace_event_unittest.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
nednguyen
6 years, 4 months ago (2014-07-30 18:10:21 UTC) #1
jam
I'm not familiar with this code and I'm not an owner in this directory.. just ...
6 years, 4 months ago (2014-07-30 20:41:27 UTC) #2
nednguyen
On 2014/07/30 20:41:27, jam wrote: > I'm not familiar with this code and I'm not ...
6 years, 4 months ago (2014-07-30 21:17:32 UTC) #3
nednguyen
6 years, 4 months ago (2014-08-04 22:44:19 UTC) #4
dsinclair
lgtm
6 years, 4 months ago (2014-08-05 14:57:27 UTC) #5
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-05 14:58:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/432473002/1
6 years, 4 months ago (2014-08-05 15:00:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 15:10:33 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 15:12:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/1872) mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/3091)
6 years, 4 months ago (2014-08-05 15:12:12 UTC) #10
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-05 15:30:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/432473002/20001
6 years, 4 months ago (2014-08-05 15:32:04 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 18:16:59 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 18:27:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42675)
6 years, 4 months ago (2014-08-05 18:27:34 UTC) #15
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-05 22:43:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/432473002/20001
6 years, 4 months ago (2014-08-05 22:44:57 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 05:49:06 UTC) #18
Message was sent while issue was closed.
Change committed as 287690

Powered by Google App Engine
This is Rietveld 408576698