Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 412033003: Update trace_event_unittest to use ASSERT_LE rather than ASSERT_LT. (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update trace_event_unittest to use ASSERT_LE rather than ASSERT_LT. BUG=396403 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/debug/trace_event_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-23 22:15:42 UTC) #1
jam
i'm not an owner in this directory and i'm not familiar with the code
6 years, 5 months ago (2014-07-24 01:25:43 UTC) #2
dsinclair
lgtm
6 years, 5 months ago (2014-07-24 17:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/412033003/1
6 years, 5 months ago (2014-07-24 17:20:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 20:29:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 21:02:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2045)
6 years, 5 months ago (2014-07-24 21:02:25 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-24 21:08:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/412033003/1
6 years, 5 months ago (2014-07-24 21:09:47 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:45:43 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:19:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2113)
6 years, 5 months ago (2014-07-24 22:19:14 UTC) #12
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-25 02:58:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/412033003/1
6 years, 5 months ago (2014-07-25 03:00:20 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 03:35:49 UTC) #15
Message was sent while issue was closed. 
Change committed as 285472

Powered by Google App Engine
This is Rietveld 408576698