Issue 43243002: IDL compiler: Sync Python compiler to WrapperTypeInfo changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43243002: IDL compiler: Sync Python compiler to WrapperTypeInfo changes (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)

Modified:
7 years, 2 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: Sync Python compiler to WrapperTypeInfo changes Sync to 2 recent changes info => wrapperTypeInfo IDL compiler: rename WrapperTypeInfo info => wrapperTypeInfo https://codereview.chromium.org/39393004/ const_cast<WrapperTypeInfo*> Make wrapperTypeInfo static member const in bindings classes https://codereview.chromium.org/40433002/ BUG=239771 NOTRY=true TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160542

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	Source/bindings/templates/interface.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/templates/interface.cpp	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/bindings/templates/interface_base.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

Quick sync. https://codereview.chromium.org/43243002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py File Source/bindings/scripts/unstable/v8_attributes.py (right): https://codereview.chromium.org/43243002/diff/1/Source/bindings/scripts/unstable/v8_attributes.py#newcode103 Source/bindings/scripts/unstable/v8_attributes.py:103: return contents ...also one last "global includes" ...

7 years, 2 months ago (2013-10-25 05:32:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/43243002/1

7 years, 2 months ago (2013-10-25 05:32:06 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages