src/compiler/arm64/code-generator-arm64.cc - Issue 432373002: [turbofan] Add support for Int32SubWithOverflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 432373002: [turbofan] Add support for Int32SubWithOverflow. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/arm64/code-generator-arm64.cc

diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc

index 91bbc2d1d919efbbe4daaddcad8e638573deed5a..85a5c580db0bfb2642f83596bca1c9655a3be6eb 100644

--- a/src/compiler/arm64/code-generator-arm64.cc

+++ b/src/compiler/arm64/code-generator-arm64.cc

@@ -243,7 +243,12 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

__ Sub(i.OutputRegister(), i.InputRegister(0), i.InputOperand(1));

break;

case kArm64Sub32:

- __ Sub(i.OutputRegister32(), i.InputRegister32(0), i.InputOperand32(1));

+ if (FlagsModeField::decode(opcode) != kFlags_none) {

+ __ Subs(i.OutputRegister32(), i.InputRegister32(0),

+ i.InputOperand32(1));

+ } else {

+ __ Sub(i.OutputRegister32(), i.InputRegister32(0), i.InputOperand32(1));

+ }

break;

case kArm64Shl:

ASSEMBLE_SHIFT(Lsl, 64);