Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 432373002: [turbofan] Add support for Int32SubWithOverflow. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for Int32SubWithOverflow. TEST=cctest/test-run-machops,cctest/test-instruction-selector-arm R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -267 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-node-factory.h View 2 chunks +12 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction-selector-arm.cc View 3 chunks +272 lines, -264 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-01 11:21:57 UTC) #1
titzer
lgtm
6 years, 4 months ago (2014-08-01 12:17:52 UTC) #2
Benedikt Meurer
6 years, 4 months ago (2014-08-01 12:18:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22791 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698