Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h

Issue 431973006: Fix flakiness of DesktopDragDropClientAuraX11Tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
diff --git a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
index cf3665ecac6c8d968340e85121419cf6570c0bbd..e4a8adad1ef4bd6e01c7bcee295a756e0fd469bc 100644
--- a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
+++ b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
@@ -12,7 +12,8 @@
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/vector2d_f.h"
-#include "ui/views/widget/desktop_aura/x11_whole_screen_move_loop_delegate.h"
+#include "ui/views/widget/desktop_aura/x11_move_loop.h"
+#include "ui/views/widget/desktop_aura/x11_move_loop_delegate.h"
typedef struct _XDisplay XDisplay;
@@ -30,29 +31,23 @@ class Widget;
// Runs a nested message loop and grabs the mouse. This is used to implement
// dragging.
-class X11WholeScreenMoveLoop : public ui::PlatformEventDispatcher {
+class X11WholeScreenMoveLoop : public X11MoveLoop,
+ public ui::PlatformEventDispatcher {
public:
- explicit X11WholeScreenMoveLoop(X11WholeScreenMoveLoopDelegate* delegate);
+ explicit X11WholeScreenMoveLoop(X11MoveLoopDelegate* delegate);
virtual ~X11WholeScreenMoveLoop();
// ui:::PlatformEventDispatcher:
virtual bool CanDispatchEvent(const ui::PlatformEvent& event) OVERRIDE;
virtual uint32_t DispatchEvent(const ui::PlatformEvent& event) OVERRIDE;
- // Runs the nested message loop. While the mouse is grabbed, use |cursor| as
- // the mouse cursor. Returns true if the move-loop is completed successfully.
- // If the pointer-grab fails, or the move-loop is canceled by the user (e.g.
- // by pressing escape), then returns false.
- bool RunMoveLoop(aura::Window* window, gfx::NativeCursor cursor);
-
- // Updates the cursor while the move loop is running.
- void UpdateCursor(gfx::NativeCursor cursor);
-
- // Ends the RunMoveLoop() that's currently in progress.
- void EndMoveLoop();
-
- // Sets an image to be used during the drag.
- void SetDragImage(const gfx::ImageSkia& image, gfx::Vector2dF offset);
+ // X11MoveLoop:
+ virtual bool RunMoveLoop(aura::Window* window,
+ gfx::NativeCursor cursor) OVERRIDE;
+ virtual void UpdateCursor(gfx::NativeCursor cursor) OVERRIDE;
+ virtual void EndMoveLoop() OVERRIDE;
+ virtual void SetDragImage(const gfx::ImageSkia& image,
+ const gfx::Vector2dF& offset) OVERRIDE;
private:
// Grabs the pointer and keyboard, setting the mouse cursor to |cursor|.
@@ -72,7 +67,7 @@ class X11WholeScreenMoveLoop : public ui::PlatformEventDispatcher {
// Dispatch mouse movement event to |delegate_| in a posted task.
void DispatchMouseMovement();
- X11WholeScreenMoveLoopDelegate* delegate_;
+ X11MoveLoopDelegate* delegate_;
// Are we running a nested message loop from RunMoveLoop()?
bool in_move_loop_;
« no previous file with comments | « ui/views/widget/desktop_aura/x11_move_loop_delegate.h ('k') | ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698