gn win: Enable exceptions for pdfium build

gn win: Enable exceptions for pdfium build

Homogenizes with gcc to make a consistent way to enable exceptions for
a target.

Needs to include roll of https://codereview.chromium.org/426153007/ after that lands

R=brettw@chromium.org
BUG=354261

[brettw, 2014-07-30 22:15:48]

Can you unify this with the build/config/gcc:no_exceptions so there's a uniform
way to enable exceptions for a target?

[scottmg, 2014-07-30 22:17:40]

On 2014/07/30 22:15:48, brettw wrote:
> Can you unify this with the build/config/gcc:no_exceptions so there's a
uniform
> way to enable exceptions for a target?

Yeah, build/config/compiler?

It'll have to be configs += exceptions; configs -= no_exceptions though still
right?

[brettw, 2014-07-30 22:22:53]

Yeah, I guess so

[scottmg, 2014-07-30 22:28:50]

On 2014/07/30 22:15:48, brettw wrote:
> Can you unify this with the build/config/gcc:no_exceptions so there's a
uniform
> way to enable exceptions for a target?

Done.

[brettw, 2014-07-30 22:41:36]

lgtm

[scottmg, 2014-07-30 22:48:00]

Oh, I was confused. Needs to land the pdfium file in
https://codereview.chromium.org/426153007/ and include the roll in this CL.

[scottmg, 2014-07-31 22:38:01]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2014-07-31 22:38:47]

+jam fyi for pdfium roll

[commit-bot: I haz the power, 2014-07-31 22:39:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/431803003/60001

[Nico, 2014-07-31 23:15:23]

Also, https://code.google.com/p/pdfium/issues/detail?id=28 fyi

https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
"//build/config/compiler:exceptions" ]
This isn't right, see https://codereview.chromium.org/419973003/ (or that change
is wrong, I suppose)

[Nico, 2014-07-31 23:15:33]

The CQ bit was unchecked by thakis@chromium.org

[scottmg, 2014-07-31 23:24:31]

Ah, thanks.

https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
"//build/config/compiler:exceptions" ]
On 2014/07/31 23:15:23, Nico (away) wrote:
> This isn't right, see https://codereview.chromium.org/419973003/ (or that
change
> is wrong, I suppose)

OK, this is mostly just a port of existing behaviour, so I'm going to let it go
as pdfium can't roll until this lands (because I moved the posix one).

So we don't have any reason to enable exceptions any longer? Or just not based
on shared/static?

[scottmg, 2014-07-31 23:26:41]

On 2014/07/31 23:24:31, scottmg wrote:
> Ah, thanks.
> 
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
> File build/config/BUILDCONFIG.gn (right):
> 
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
> build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
> "//build/config/compiler:exceptions" ]
> On 2014/07/31 23:15:23, Nico (away) wrote:
> > This isn't right, see https://codereview.chromium.org/419973003/ (or that
> change
> > is wrong, I suppose)
> 
> OK, this is mostly just a port of existing behaviour, so I'm going to let it
go
> as pdfium can't roll until this lands (because I moved the posix one).
> 
> So we don't have any reason to enable exceptions any longer? Or just not based
> on shared/static?

Never mind, I'm dopey. Of course we need this for pdfium still.

I'll fix the shared_library in a followup.

[Nico, 2014-07-31 23:28:47]

On 2014/07/31 23:26:41, scottmg wrote:
> On 2014/07/31 23:24:31, scottmg wrote:
> > Ah, thanks.
> > 
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
> > File build/config/BUILDCONFIG.gn (right):
> > 
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
> > build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
> > "//build/config/compiler:exceptions" ]
> > On 2014/07/31 23:15:23, Nico (away) wrote:
> > > This isn't right, see https://codereview.chromium.org/419973003/ (or that
> > change
> > > is wrong, I suppose)
> > 
> > OK, this is mostly just a port of existing behaviour, so I'm going to let it
> go
> > as pdfium can't roll until this lands (because I moved the posix one).
> > 
> > So we don't have any reason to enable exceptions any longer? Or just not
based
> > on shared/static?

Just not based on shared/static for now, but
https://code.google.com/p/pdfium/issues/detail?id=28 is hopefully fixed soon and
then we won't need them anywhere.

(If you think landing this cl is the right thing to do for now, do go ahead, i
just unchecked to make sure that you see my note)

> 
> Never mind, I'm dopey. Of course we need this for pdfium still.
> 
> I'll fix the shared_library in a followup.

[scottmg, 2014-07-31 23:29:03]

On 2014/07/31 23:26:41, scottmg wrote:
> On 2014/07/31 23:24:31, scottmg wrote:
> > Ah, thanks.
> > 
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
> > File build/config/BUILDCONFIG.gn (right):
> > 
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
> > build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
> > "//build/config/compiler:exceptions" ]
> > On 2014/07/31 23:15:23, Nico (away) wrote:
> > > This isn't right, see https://codereview.chromium.org/419973003/ (or that
> > change
> > > is wrong, I suppose)
> > 
> > OK, this is mostly just a port of existing behaviour, so I'm going to let it
> go
> > as pdfium can't roll until this lands (because I moved the posix one).
> > 
> > So we don't have any reason to enable exceptions any longer? Or just not
based
> > on shared/static?
> 
> Never mind, I'm dopey. Of course we need this for pdfium still.
> 
> I'll fix the shared_library in a followup.

Hm, pdfium doesn't build at head anyway. I guess it's not too urgent to make it
rollable then, so I guess I'll just do it now (ish).

[scottmg, 2014-07-31 23:35:46]

On 2014/07/31 23:28:47, Nico (away) wrote:
> On 2014/07/31 23:26:41, scottmg wrote:
> > On 2014/07/31 23:24:31, scottmg wrote:
> > > Ah, thanks.
> > > 
> > >
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
> > > File build/config/BUILDCONFIG.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
> > > build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
> > > "//build/config/compiler:exceptions" ]
> > > On 2014/07/31 23:15:23, Nico (away) wrote:
> > > > This isn't right, see https://codereview.chromium.org/419973003/ (or
that
> > > change
> > > > is wrong, I suppose)
> > > 
> > > OK, this is mostly just a port of existing behaviour, so I'm going to let
it
> > go
> > > as pdfium can't roll until this lands (because I moved the posix one).
> > > 
> > > So we don't have any reason to enable exceptions any longer? Or just not
> based
> > > on shared/static?
> 
> Just not based on shared/static for now, but
> https://code.google.com/p/pdfium/issues/detail?id=28 is hopefully fixed soon
and
> then we won't need them anywhere.

Great!

> 
> (If you think landing this cl is the right thing to do for now, do go ahead, i
> just unchecked to make sure that you see my note)
> 
> > 
> > Never mind, I'm dopey. Of course we need this for pdfium still.
> > 
> > I'll fix the shared_library in a followup.

[scottmg, 2014-08-01 00:02:11]

On 2014/07/31 23:35:46, scottmg wrote:
> On 2014/07/31 23:28:47, Nico (away) wrote:
> > On 2014/07/31 23:26:41, scottmg wrote:
> > > On 2014/07/31 23:24:31, scottmg wrote:
> > > > Ah, thanks.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG.gn
> > > > File build/config/BUILDCONFIG.gn (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/431803003/diff/60001/build/config/BUILDCONFIG...
> > > > build/config/BUILDCONFIG.gn:328: _native_compiler_configs += [
> > > > "//build/config/compiler:exceptions" ]
> > > > On 2014/07/31 23:15:23, Nico (away) wrote:
> > > > > This isn't right, see https://codereview.chromium.org/419973003/ (or
> that
> > > > change
> > > > > is wrong, I suppose)
> > > > 
> > > > OK, this is mostly just a port of existing behaviour, so I'm going to
let
> it
> > > go
> > > > as pdfium can't roll until this lands (because I moved the posix one).
> > > > 
> > > > So we don't have any reason to enable exceptions any longer? Or just not
> > based
> > > > on shared/static?
> > 
> > Just not based on shared/static for now, but
> > https://code.google.com/p/pdfium/issues/detail?id=28 is hopefully fixed soon
> and
> > then we won't need them anywhere.
> 
> Great!
> 
> > 
> > (If you think landing this cl is the right thing to do for now, do go ahead,
i
> > just unchecked to make sure that you see my note)
> > 
> > > 
> > > Never mind, I'm dopey. Of course we need this for pdfium still.
> > > 
> > > I'll fix the shared_library in a followup.

Bleh: https://code.google.com/p/pdfium/issues/detail?id=31