Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 431803003: gn win: Enable exceptions for pdfium build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: include pdfium roll Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index b05247e92ee117c7cfa055aa8d2112d530b5416e..01d59fd46f9a01ec6323d9c9eeca8846e80348ff 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -324,10 +324,17 @@ if (is_win) {
"//build/config/win:sdk",
"//build/config/win:unicode",
]
+ if (is_component_build) {
+ _native_compiler_configs += [ "//build/config/compiler:exceptions" ]
Nico 2014/07/31 23:15:23 This isn't right, see https://codereview.chromium.
scottmg 2014/07/31 23:24:31 OK, this is mostly just a port of existing behavio
+ } else {
+ # We don't use exceptions, and when we link statically we can just get
+ # rid of them entirely.
+ _native_compiler_configs += [ "//build/config/compiler:no_exceptions" ]
+ }
}
if (is_posix) {
_native_compiler_configs += [
- "//build/config/gcc:no_exceptions",
+ "//build/config/compiler:no_exceptions",
"//build/config/gcc:symbol_visibility_hidden",
]
}
« no previous file with comments | « DEPS ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698