Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 431503002: Implement autosizing for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index 3c8c4f5666259bf073bae23f9ecff3a27a6843c4..ebfb825e6a116f42fef162477d1a3edf9ef91411 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -138,3 +138,13 @@ void ExtensionOptionsGuest::OnRequest(
extension_function_dispatcher_->Dispatch(
params, guest_web_contents()->GetRenderViewHost());
}
+
+void ExtensionOptionsGuest::SizeChanged(const gfx::Size& old_size,
+ const gfx::Size& new_size) {
not at google - send to devlin 2014/07/30 17:44:56 indentation
ericzeng 2014/07/30 23:29:26 Done.
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ args->SetInteger(extensionoptions::kWidth, new_size.width());
+ args->SetInteger(extensionoptions::kHeight, new_size.height());
not at google - send to devlin 2014/07/30 17:44:57 better: OnSizeChanged event; event.width = new_si
ericzeng 2014/07/30 23:29:26 GuestViewBase would need some refactoring in order
+ DispatchEventToEmbedder(new GuestViewBase::Event(
+ extensions::api::extension_options_internal::OnSizeChanged::kEventName,
not at google - send to devlin 2014/07/30 17:44:56 you might want to "using extensions::api::extensio
ericzeng 2014/07/30 23:29:25 Done.
+ args.Pass()));
+}

Powered by Google App Engine
This is Rietveld 408576698