Implement autosizing for <extensionoptions>

chrome/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 120 matching lines @@
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ExtensionOptionsGuest::OnRequest(
     const ExtensionHostMsg_Request_Params& params) {
   extension_function_dispatcher_->Dispatch(
       params, guest_web_contents()->GetRenderViewHost());
 }
+
+void ExtensionOptionsGuest::SizeChanged(const gfx::Size& old_size,
+                                       const gfx::Size& new_size) {

[not at google - send to devlin, 2014/07/30 17:44:56]

indentation

[ericzeng, 2014/07/30 23:29:26]

Done.

+  scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+  args->SetInteger(extensionoptions::kWidth, new_size.width());
+  args->SetInteger(extensionoptions::kHeight, new_size.height());

[not at google - send to devlin, 2014/07/30 17:44:57]

better:

OnSizeChanged event;
event.width = new_size.width();
event.height = new_size.height();
DispatchEventToEmbedder(new GuestViewBase::Event(
    OnSizeChanged::kEventName, event.ToValue()));

or thereabouts.

[ericzeng, 2014/07/30 23:29:26]

GuestViewBase would need some refactoring in order to make this change.
OnSizeChanged::Create returns a base::ListValue, but GuestViewBase::Event
requires a base::DictionaryValue in the constructor. 

+  DispatchEventToEmbedder(new GuestViewBase::Event(
+      extensions::api::extension_options_internal::OnSizeChanged::kEventName,

[not at google - send to devlin, 2014/07/30 17:44:56]

you might want to "using extensions::api::extension_options_internal" at the top
to pull all of these in.

[ericzeng, 2014/07/30 23:29:25]

Done.

+      args.Pass()));
+}