Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 431323003: Implement --v8-cache-options (instead of --enable-preparsed-js-caching) (Closed)

Created:
6 years, 4 months ago by vogelheim
Modified:
6 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement --v8-cache-options (instead of --enable-preparsed-js-caching) and send the option value via Preferences to the renderer. BUG=399580 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288969

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : Fixup after rebase. #

Patch Set 6 : More fixup after more rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -34 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 5 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/web_preferences.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jochen (gone - plz use gerrit)
lgtm you'll need a security review for the IPC changes (try nasko@) https://codereview.chromium.org/431323003/diff/60001/content/public/common/web_preferences.cc File content/public/common/web_preferences.cc ...
6 years, 4 months ago (2014-08-06 11:27:57 UTC) #1
vogelheim
https://codereview.chromium.org/431323003/diff/60001/content/public/common/web_preferences.cc File content/public/common/web_preferences.cc (right): https://codereview.chromium.org/431323003/diff/60001/content/public/common/web_preferences.cc#newcode40 content/public/common/web_preferences.cc:40: COMPILE_ASSERT_MATCHING_ENUMS(V8_CACHE_OPTIONS_LAST, On 2014/08/06 11:27:57, jochen wrote: > i think ...
6 years, 4 months ago (2014-08-06 11:34:10 UTC) #2
nasko
You could've just passed the command line to the renderer and check it there, but ...
6 years, 4 months ago (2014-08-06 11:51:05 UTC) #3
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 4 months ago (2014-08-11 17:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vogelheim@chromium.org/431323003/100001
6 years, 4 months ago (2014-08-11 17:05:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 20:47:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 21:29:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4696)
6 years, 4 months ago (2014-08-11 21:29:05 UTC) #8
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 4 months ago (2014-08-12 11:34:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vogelheim@chromium.org/431323003/120001
6 years, 4 months ago (2014-08-12 11:36:01 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 13:21:25 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:09:02 UTC) #12
Message was sent while issue was closed. 
Change committed as 288969

Powered by Google App Engine
This is Rietveld 408576698