Implement --v8-cache-options (instead of --enable-preparsed-js-caching)

content/public/common/web_preferences.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/web_preferences.h"
 
 #include "base/basictypes.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "third_party/WebKit/public/web/WebSettings.h"
@@ skipping 13 matching lines @@
 
 COMPILE_ASSERT_MATCHING_ENUMS(EDITING_BEHAVIOR_MAC,
                               WebSettings::EditingBehaviorMac);
 COMPILE_ASSERT_MATCHING_ENUMS(EDITING_BEHAVIOR_WIN,
                               WebSettings::EditingBehaviorWin);
 COMPILE_ASSERT_MATCHING_ENUMS(EDITING_BEHAVIOR_UNIX,
                               WebSettings::EditingBehaviorUnix);
 COMPILE_ASSERT_MATCHING_ENUMS(EDITING_BEHAVIOR_ANDROID,
                               WebSettings::EditingBehaviorAndroid);
 
+COMPILE_ASSERT_MATCHING_ENUMS(V8_CACHE_OPTIONS_OFF,
+                              WebSettings::V8CacheOptionsOff);
+COMPILE_ASSERT_MATCHING_ENUMS(V8_CACHE_OPTIONS_PARSE,
+                              WebSettings::V8CacheOptionsParse);
+COMPILE_ASSERT_MATCHING_ENUMS(V8_CACHE_OPTIONS_CODE,
+                              WebSettings::V8CacheOptionsCode);
+COMPILE_ASSERT_MATCHING_ENUMS(V8_CACHE_OPTIONS_LAST,

[jochen (gone - plz use gerrit), 2014/08/06 11:27:57]

i think this one is not necessary

[vogelheim, 2014/08/06 11:34:10]

I agree, but... the whole triplicate enum + static_cast + assert seemed rather
fragile to me and this is the only check that would guard against /new/ values
being added and forgotten in one of the intermediate steps.

+                              WebSettings::V8CacheOptionsCode);
+
 WebPreferences::WebPreferences()
     : default_font_size(16),
       default_fixed_font_size(13),
       minimum_font_size(0),
       minimum_logical_font_size(6),
       default_encoding("ISO-8859-1"),
       javascript_enabled(true),
       web_security_enabled(true),
       javascript_can_open_windows_automatically(true),
       loads_images_automatically(true),
@@ skipping 116 matching lines @@
   cursive_font_family_map[kCommonScript] = base::ASCIIToUTF16("Script");
   fantasy_font_family_map[kCommonScript] = base::ASCIIToUTF16("Impact");
   pictograph_font_family_map[kCommonScript] =
       base::ASCIIToUTF16("Times New Roman");
 }
 
 WebPreferences::~WebPreferences() {
 }
 
 }  // namespace content