Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/common/blob/blob_data.cc

Issue 431143002: Remove failing DCHECKs in Blob code. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed feedback. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/browser/blob/blob_storage_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/common/blob/blob_data.cc
diff --git a/webkit/common/blob/blob_data.cc b/webkit/common/blob/blob_data.cc
index 368186195163ad219c0705a0625e09c1e7bb70d6..a09a1a31899f6a7f3268093ae1403cc8ff38ac9e 100644
--- a/webkit/common/blob/blob_data.cc
+++ b/webkit/common/blob/blob_data.cc
@@ -27,7 +27,6 @@ void BlobData::AppendData(const char* data, size_t length) {
void BlobData::AppendFile(const base::FilePath& file_path,
uint64 offset, uint64 length,
const base::Time& expected_modification_time) {
- DCHECK(length > 0);
items_.push_back(Item());
items_.back().SetToFilePathRange(file_path, offset, length,
expected_modification_time);
@@ -44,7 +43,6 @@ void BlobData::AppendFileSystemFile(
const GURL& url, uint64 offset,
uint64 length,
const base::Time& expected_modification_time) {
- DCHECK(length > 0);
items_.push_back(Item());
items_.back().SetToFileSystemUrlRange(url, offset, length,
expected_modification_time);
« no previous file with comments | « webkit/browser/blob/blob_storage_context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698