webkit/browser/blob/blob_storage_context.cc - Issue 431143002: Remove failing DCHECKs in Blob code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/blob/blob_storage_context.cc

Issue 431143002: Remove failing DCHECKs in Blob code. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/browser/blob/blob_storage_context.cc

diff --git a/webkit/browser/blob/blob_storage_context.cc b/webkit/browser/blob/blob_storage_context.cc

index f62a26dbe545aed3ab1bd27c1d6a83096670cd7e..fe1eec368f13d7c4b493c2b9ba0c015c00447e7e 100644

--- a/webkit/browser/blob/blob_storage_context.cc

+++ b/webkit/browser/blob/blob_storage_context.cc

@@ -143,7 +143,6 @@ void BlobStorageContext::AppendBlobDataItem(

// 4) The Blob items are expanded.

// TODO(michaeln): Would be nice to avoid copying Data items when expanding.

- DCHECK(item.length() > 0);

switch (item.type()) {

case BlobData::Item::TYPE_BYTES:

DCHECK(!item.offset());