Issue 431025: Make calloc return NULL while initializing....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431025: Make calloc return NULL while initializing.... (Closed)

Created:
11 years, 1 month ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make calloc return NULL while initializing. BUG=28244 TEST=Run chrome in shared library mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32953

Patch Set 2 : De-macroize unique functions #

Total comments: 1

Patch Set 3 : static null-calloc #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -18 lines)			Patch
	M	base/process_util_linux.cc	View	1 2	2 chunks	+37 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/431025/diff/1/2 File base/process_util_linux.cc (right): http://codereview.chromium.org/431025/diff/1/2#newcode608 base/process_util_linux.cc:608: DIE_ON_OOM_2_NULL_ON_INIT(calloc, size_t) Since there is only one use of ...

11 years, 1 month ago (2009-11-24 04:29:20 UTC) #1

vandebo (ex-Chrome)

On 2009/11/24 04:29:20, Evan Martin wrote: > Since there is only one use of this, ...

11 years, 1 month ago (2009-11-24 18:30:00 UTC) #2