Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 431025: Make calloc return NULL while initializing.... (Closed)

Created:
11 years, 1 month ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org
Visibility:
Public.

Description

Make calloc return NULL while initializing. BUG=28244 TEST=Run chrome in shared library mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32953

Patch Set 1 #

Total comments: 1

Patch Set 2 : De-macroize unique functions #

Total comments: 1

Patch Set 3 : static null-calloc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M base/process_util_linux.cc View 1 2 2 chunks +37 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
http://codereview.chromium.org/431025/diff/1/2 File base/process_util_linux.cc (right): http://codereview.chromium.org/431025/diff/1/2#newcode608 base/process_util_linux.cc:608: DIE_ON_OOM_2_NULL_ON_INIT(calloc, size_t) Since there is only one use of ...
11 years, 1 month ago (2009-11-24 04:29:20 UTC) #1
vandebo (ex-Chrome)
On 2009/11/24 04:29:20, Evan Martin wrote: > Since there is only one use of this, ...
11 years, 1 month ago (2009-11-24 18:30:00 UTC) #2
Evan Martin
11 years, 1 month ago (2009-11-24 18:32:01 UTC) #3
LGTM

http://codereview.chromium.org/431025/diff/3001/3002
File base/process_util_linux.cc (right):

http://codereview.chromium.org/431025/diff/3001/3002#newcode575
base/process_util_linux.cc:575: void* null_calloc(size_t nmemb, size_t size) {
should this be static?

Powered by Google App Engine
This is Rietveld 408576698