Fix to prevent selecting a popup menu item from crashing when the item is aut...

chrome/browser/cocoa/download_item_controller.mm

Index: chrome/browser/cocoa/download_item_controller.mm
===================================================================
--- chrome/browser/cocoa/download_item_controller.mm	(revision 32802)
+++ chrome/browser/cocoa/download_item_controller.mm	(working copy)
@@ -203,9 +203,11 @@
     else if (download->state() == DownloadItem::COMPLETE)
       download_util::OpenDownload(download);
   } else {
+    // Hold a reference in case the download completes and we're auto-removed.

[pink (ping after 24hrs), 2009/11/24 15:06:02]

expand on what "auto-removing" is.

+    scoped_nsobject<DownloadItemController> ref([self retain]);
     [NSMenu popUpContextMenu:currentMenu_
-               withEvent:[NSApp currentEvent]
-                 forView:progressView_];
+                   withEvent:[NSApp currentEvent]
+                     forView:progressView_];
   }
 }