Fix to prevent selecting a popup menu item from crashing when the item is aut...

chrome/browser/cocoa/download_item_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/download_item_controller.h"
 
 #include "app/gfx/text_elider.h"
 #include "app/l10n_util_mac.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
@@ skipping 185 matching lines @@
 }
 
 - (IBAction)handleButtonClick:(id)sender {
   if ([cell_ isButtonPartPressed]) {
     DownloadItem* download = bridge_->download_model()->download();
     if (download->state() == DownloadItem::IN_PROGRESS)
       download->set_open_when_complete(!download->open_when_complete());
     else if (download->state() == DownloadItem::COMPLETE)
       download_util::OpenDownload(download);
   } else {
+    // Hold a reference in case the download completes and we're auto-removed.

[pink (ping after 24hrs), 2009/11/24 15:06:02]

expand on what "auto-removing" is.

+    scoped_nsobject<DownloadItemController> ref([self retain]);
     [NSMenu popUpContextMenu:currentMenu_
-               withEvent:[NSApp currentEvent]
-                 forView:progressView_];
+                   withEvent:[NSApp currentEvent]
+                     forView:progressView_];
   }
 }
 
 - (NSSize)preferredSize {
   if (state_ == kNormal)
     return [progressView_ frame].size;
   DCHECK_EQ(kDangerous, state_);
   return [dangerousDownloadView_ frame].size;
 }
 
@@ skipping 99 matching lines @@
 
 - (IBAction)handleReveal:(id)sender {
   menuBridge_->ExecuteItemCommand(DownloadShelfContextMenuMac::SHOW_IN_FOLDER);
 }
 
 - (IBAction)handleCancel:(id)sender {
   menuBridge_->ExecuteItemCommand(DownloadShelfContextMenuMac::CANCEL);
 }
 
 @end