Issue 431019: Fix to prevent selecting a popup menu item from crashing when the item is aut...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431019: Fix to prevent selecting a popup menu item from crashing when the item is aut... (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix to prevent selecting a popup menu item from crashing when the item is auto-opened. BUG=http://crbug.com/28215 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32925

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/download_item_controller.mm	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

lgtm http://codereview.chromium.org/431019/diff/1/2 File chrome/browser/cocoa/download_item_controller.mm (right): http://codereview.chromium.org/431019/diff/1/2#newcode206 chrome/browser/cocoa/download_item_controller.mm:206: // Hold a reference in case the download ...

11 years, 1 month ago (2009-11-24 15:06:02 UTC) #3

Mark Mentovai

11 years, 1 month ago (2009-11-24 20:59:46 UTC) #4

LGTM.

Sorry I missed this yesterday.  I actually JUST saw it.  Gmail's been doing some
funny things with some of my messages, apparently.

Expand Messages | Collapse Messages