Issue 43083: Relanding layout test fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43083: Relanding layout test fix (Closed)

Created:
11 years, 9 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Relanding a backed-out CL: The navigation entry's state would not be returned for navigation entries of error pages (such as 404). This was causing the following problems when navigating back to a 404 page in test shell: - a new entry to be created instead of going back to the existing entry - the navTarget property not to be set on the HistoryItem That was causing the LayoutTests/http/tests/navigation/error404-goback.html failure. It seems safe to return the navigation entry's state for an error page. BUG=None TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11453

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	webkit/glue/webframe_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

Relanding this change. After some more investigations, I am still not sure why it failed ...

11 years, 9 months ago (2009-03-11 16:44:42 UTC) #1

OK, good luck.

Expand Messages | Collapse Messages