Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: webkit/glue/webframe_impl.cc

Issue 43083: Relanding layout test fix (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/tools/layout_tests/test_lists/tests_fixable.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 2 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
3 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 3 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 } 485 }
486 return GURL(); 486 return GURL();
487 } 487 }
488 488
489 bool WebFrameImpl::GetPreviousHistoryState(std::string* history_state) const { 489 bool WebFrameImpl::GetPreviousHistoryState(std::string* history_state) const {
490 // We use the previous item here because documentState (filled-out forms) 490 // We use the previous item here because documentState (filled-out forms)
491 // only get saved to history when it becomes the previous item. The caller 491 // only get saved to history when it becomes the previous item. The caller
492 // is expected to query the history state after a navigation occurs, after 492 // is expected to query the history state after a navigation occurs, after
493 // the desired history item has become the previous entry. 493 // the desired history item has become the previous entry.
494 RefPtr<HistoryItem> item = webview_impl_->GetPreviousHistoryItem(); 494 RefPtr<HistoryItem> item = webview_impl_->GetPreviousHistoryItem();
495 if (!item || item->lastVisitWasFailure()) 495 if (!item)
496 return false; 496 return false;
497 497
498 static StatsCounterTimer history_timer("GetHistoryTimer"); 498 static StatsCounterTimer history_timer("GetHistoryTimer");
499 StatsScope<StatsCounterTimer> history_scope(history_timer); 499 StatsScope<StatsCounterTimer> history_scope(history_timer);
500 500
501 webkit_glue::HistoryItemToString(item, history_state); 501 webkit_glue::HistoryItemToString(item, history_state);
502 return true; 502 return true;
503 } 503 }
504 504
505 bool WebFrameImpl::GetCurrentHistoryState(std::string* state) const { 505 bool WebFrameImpl::GetCurrentHistoryState(std::string* state) const {
(...skipping 1339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1845 return password_listeners_.get(input_element); 1845 return password_listeners_.get(input_element);
1846 } 1846 }
1847 1847
1848 void WebFrameImpl::ClearPasswordListeners() { 1848 void WebFrameImpl::ClearPasswordListeners() {
1849 for (PasswordListenerMap::iterator iter = password_listeners_.begin(); 1849 for (PasswordListenerMap::iterator iter = password_listeners_.begin();
1850 iter != password_listeners_.end(); ++iter) { 1850 iter != password_listeners_.end(); ++iter) {
1851 delete iter->second; 1851 delete iter->second;
1852 } 1852 }
1853 password_listeners_.clear(); 1853 password_listeners_.clear();
1854 } 1854 }
OLDNEW
« no previous file with comments | « no previous file | webkit/tools/layout_tests/test_lists/tests_fixable.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698