Issue 430793002: Eliminate MediaPlayer abstraction(paint APIs)

Issue 430793002: Eliminate MediaPlayer abstraction(paint APIs) (Closed)

Created:
6 years, 4 months ago by Srirama

Modified:
6 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, philipj_slow, abarth-chromium

CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, danakj, dglazkov+blink, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, jbroman, jchaffraix+rendering, leviw+renderwatch, pdr., philipj_slow, rwlbuis, rune+blink, Stephen Chennney, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Eliminate MediaPlayer abstraction(paint APIs) BUG=350571 chromium side patch (android): https://codereview.chromium.org/409793006/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179245

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fixed review comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -115 lines)			Patch
M	Source/core/html/HTMLVideoElement.h	View	1	3 chunks	+9 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View	1	2 chunks	+16 lines, -6 lines	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderVideo.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/media/MediaPlayer.h	View		3 chunks	+0 lines, -14 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.h	View		4 chunks	+0 lines, -18 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.cpp	View		2 chunks	+0 lines, -74 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Srirama

Removed paint related APIs from webmediaplayerclientimpl.cpp Android dependent changes have already landed https://codereview.chromium.org/409793006/ PTAL.

6 years, 4 months ago (2014-07-30 13:56:46 UTC) #1

abarth-chromium

What happened to the Android-specific code path? https://codereview.chromium.org/430793002/diff/20001/Source/core/html/HTMLVideoElement.cpp File Source/core/html/HTMLVideoElement.cpp (right): https://codereview.chromium.org/430793002/diff/20001/Source/core/html/HTMLVideoElement.cpp#newcode207 Source/core/html/HTMLVideoElement.cpp:207: blink::WebCanvas* canvas ...

6 years, 4 months ago (2014-07-30 16:27:40 UTC) #2

Srirama

Thanks for the quick review. Android path was moved down to chromium layer (webmediaplayer_android.cc) https://codereview.chromium.org/409793006/ ...

6 years, 4 months ago (2014-07-30 16:48:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/430793002/40001

6 years, 4 months ago (2014-07-30 18:23:25 UTC) #6

Message was sent while issue was closed.

Change committed as 179245

Expand Messages | Collapse Messages