Source/core/rendering/RenderVideo.cpp - Issue 430793002: Eliminate MediaPlayer abstraction(paint APIs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderVideo.cpp

Issue 430793002: Eliminate MediaPlayer abstraction(paint APIs) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderVideo.cpp

diff --git a/Source/core/rendering/RenderVideo.cpp b/Source/core/rendering/RenderVideo.cpp

index 8829b3816c385db8cee88d974a382f267becb759..d1a30c875b9bdd047ec7eb257e5e48dc41df3029 100644

--- a/Source/core/rendering/RenderVideo.cpp

+++ b/Source/core/rendering/RenderVideo.cpp

@@ -170,7 +170,7 @@ void RenderVideo::paintReplaced(PaintInfo& paintInfo, const LayoutPoint& paintOf

if (displayingPoster)

paintIntoRect(context, rect);

else if ((document().view() && document().view()->paintBehavior() & PaintBehaviorFlattenCompositingLayers) || !acceleratedRenderingInUse())

- mediaPlayer->paint(context, pixelSnappedIntRect(rect));

+ videoElement()->paintCurrentFrameInContext(context, pixelSnappedIntRect(rect));

if (clip)

context->restore();