Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 430763002: Revert of Add ScriptForbiddenScope to weak callbacks of DOM wrappers (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Add ScriptForbiddenScope to weak callbacks of DOM wrappers (https://codereview.chromium.org/368853002/) Reason for revert: This CL regressed performance. We'll need to re-think how to handle this situation Original issue's description: > Add ScriptForbiddenScope to weak callbacks of DOM wrappers > > It's dangerous to allow arbitrary JavaScript to run during a V8 GC. > > BUG=389445 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M Source/bindings/core/v8/DOMWrapperMap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptForbiddenScope.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
Created Revert of Add ScriptForbiddenScope to weak callbacks of DOM wrappers
6 years, 4 months ago (2014-07-30 06:01:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/430763002/1
6 years, 4 months ago (2014-07-30 06:01:20 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 06:01:21 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-30 06:01:22 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-07-30 06:19:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/430763002/1
6 years, 4 months ago (2014-07-30 06:19:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 06:19:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 06:19:38 UTC) #8
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698