Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/bindings/core/v8/ScriptWrappable.h

Issue 430763002: Revert of Add ScriptForbiddenScope to weak callbacks of DOM wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/core/v8/DOMWrapperMap.h ('k') | Source/core/dom/ScriptForbiddenScope.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ScriptWrappable_h 31 #ifndef ScriptWrappable_h
32 #define ScriptWrappable_h 32 #define ScriptWrappable_h
33 33
34 #include "bindings/core/v8/WrapperTypeInfo.h" 34 #include "bindings/core/v8/WrapperTypeInfo.h"
35 #include "core/dom/ScriptForbiddenScope.h"
36 #include "platform/heap/Handle.h" 35 #include "platform/heap/Handle.h"
37 #include <v8.h> 36 #include <v8.h>
38 37
39 // Helper to call webCoreInitializeScriptWrappableForInterface in the global nam espace. 38 // Helper to call webCoreInitializeScriptWrappableForInterface in the global nam espace.
40 template <class C> inline void initializeScriptWrappableHelper(C* object) 39 template <class C> inline void initializeScriptWrappableHelper(C* object)
41 { 40 {
42 void webCoreInitializeScriptWrappableForInterface(C*); 41 void webCoreInitializeScriptWrappableForInterface(C*);
43 webCoreInitializeScriptWrappableForInterface(object); 42 webCoreInitializeScriptWrappableForInterface(object);
44 } 43 }
45 44
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 setTypeInfo(toWrapperTypeInfo(wrapper)); 258 setTypeInfo(toWrapperTypeInfo(wrapper));
260 } 259 }
261 260
262 // If zero, then this contains nothing, otherwise: 261 // If zero, then this contains nothing, otherwise:
263 // If the bottom bit it set, then this contains a pointer to a wrapper obj ect in the remainging bits. 262 // If the bottom bit it set, then this contains a pointer to a wrapper obj ect in the remainging bits.
264 // If the bottom bit is clear, then this contains a pointer to the wrapper type info in the remaining bits. 263 // If the bottom bit is clear, then this contains a pointer to the wrapper type info in the remaining bits.
265 uintptr_t m_wrapperOrTypeInfo; 264 uintptr_t m_wrapperOrTypeInfo;
266 265
267 static void setWeakCallback(const v8::WeakCallbackData<v8::Object, ScriptWra ppable>& data) 266 static void setWeakCallback(const v8::WeakCallbackData<v8::Object, ScriptWra ppable>& data)
268 { 267 {
269 ScriptForbiddenScope forbiddenScope;
270 v8::Persistent<v8::Object> persistent; 268 v8::Persistent<v8::Object> persistent;
271 data.GetParameter()->getPersistent(&persistent); 269 data.GetParameter()->getPersistent(&persistent);
272 ASSERT(persistent == data.GetValue()); 270 ASSERT(persistent == data.GetValue());
273 data.GetParameter()->disposeWrapper(data.GetValue()); 271 data.GetParameter()->disposeWrapper(data.GetValue());
274 272
275 // FIXME: I noticed that 50%~ of minor GC cycle times can be consumed 273 // FIXME: I noticed that 50%~ of minor GC cycle times can be consumed
276 // inside data.GetParameter()->deref(), which causes Node destructions. We should 274 // inside data.GetParameter()->deref(), which causes Node destructions. We should
277 // make Node destructions incremental. 275 // make Node destructions incremental.
278 releaseObject(data.GetValue()); 276 releaseObject(data.GetValue());
279 } 277 }
280 }; 278 };
281 279
282 } // namespace WebCore 280 } // namespace WebCore
283 281
284 #endif // ScriptWrappable_h 282 #endif // ScriptWrappable_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/DOMWrapperMap.h ('k') | Source/core/dom/ScriptForbiddenScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698