Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/lookup.h

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log-utils.cc ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 5593188010612d149c1701b0eb10985f904a4805..8de9724cb2e8ca50a851d6ef77d541fe4552a717 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -95,7 +95,7 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
Handle<Map> holder_map() const { return holder_map_; }
template <class T>
Handle<T> GetHolder() const {
- ASSERT(IsFound());
+ DCHECK(IsFound());
return Handle<T>::cast(maybe_holder_.ToHandleChecked());
}
Handle<JSReceiver> GetRoot() const;
@@ -124,15 +124,15 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
PropertyAttributes attributes,
Object::StoreFromKeyed store_mode);
PropertyKind property_kind() const {
- ASSERT(has_property_);
+ DCHECK(has_property_);
return property_kind_;
}
PropertyEncoding property_encoding() const {
- ASSERT(has_property_);
+ DCHECK(has_property_);
return property_encoding_;
}
PropertyDetails property_details() const {
- ASSERT(has_property_);
+ DCHECK(has_property_);
return property_details_;
}
bool IsConfigurable() const { return !property_details().IsDontDelete(); }
@@ -176,13 +176,13 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
return (configuration_ & CHECK_ACCESS_CHECK) != 0;
}
int descriptor_number() const {
- ASSERT(has_property_);
- ASSERT_EQ(DESCRIPTOR, property_encoding_);
+ DCHECK(has_property_);
+ DCHECK_EQ(DESCRIPTOR, property_encoding_);
return number_;
}
int dictionary_entry() const {
- ASSERT(has_property_);
- ASSERT_EQ(DICTIONARY, property_encoding_);
+ DCHECK(has_property_);
+ DCHECK_EQ(DICTIONARY, property_encoding_);
return number_;
}
« no previous file with comments | « src/log-utils.cc ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698