Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: src/log-utils.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log-utils.h ('k') | src/lookup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log-utils.cc
diff --git a/src/log-utils.cc b/src/log-utils.cc
index 4149186d56968ffea07f66767d5f030394cee047..c94d07a9f29220fab5caeb252381c35821f6970c 100644
--- a/src/log-utils.cc
+++ b/src/log-utils.cc
@@ -54,19 +54,19 @@ void Log::Initialize(const char* log_file_name) {
void Log::OpenStdout() {
- ASSERT(!IsEnabled());
+ DCHECK(!IsEnabled());
output_handle_ = stdout;
}
void Log::OpenTemporaryFile() {
- ASSERT(!IsEnabled());
+ DCHECK(!IsEnabled());
output_handle_ = base::OS::OpenTemporaryFile();
}
void Log::OpenFile(const char* name) {
- ASSERT(!IsEnabled());
+ DCHECK(!IsEnabled());
output_handle_ = base::OS::FOpen(name, base::OS::LogFileOpenMode);
}
@@ -94,7 +94,7 @@ Log::MessageBuilder::MessageBuilder(Log* log)
: log_(log),
lock_guard_(&log_->mutex_),
pos_(0) {
- ASSERT(log_->message_buffer_ != NULL);
+ DCHECK(log_->message_buffer_ != NULL);
}
@@ -105,7 +105,7 @@ void Log::MessageBuilder::Append(const char* format, ...) {
va_start(args, format);
AppendVA(format, args);
va_end(args);
- ASSERT(pos_ <= Log::kMessageBufferSize);
+ DCHECK(pos_ <= Log::kMessageBufferSize);
}
@@ -120,7 +120,7 @@ void Log::MessageBuilder::AppendVA(const char* format, va_list args) {
} else {
pos_ = Log::kMessageBufferSize;
}
- ASSERT(pos_ <= Log::kMessageBufferSize);
+ DCHECK(pos_ <= Log::kMessageBufferSize);
}
@@ -128,7 +128,7 @@ void Log::MessageBuilder::Append(const char c) {
if (pos_ < Log::kMessageBufferSize) {
log_->message_buffer_[pos_++] = c;
}
- ASSERT(pos_ <= Log::kMessageBufferSize);
+ DCHECK(pos_ <= Log::kMessageBufferSize);
}
@@ -159,7 +159,7 @@ void Log::MessageBuilder::AppendAddress(Address addr) {
void Log::MessageBuilder::AppendSymbolName(Symbol* symbol) {
- ASSERT(symbol);
+ DCHECK(symbol);
Append("symbol(");
if (!symbol->name()->IsUndefined()) {
Append("\"");
@@ -206,21 +206,21 @@ void Log::MessageBuilder::AppendDetailed(String* str, bool show_impl_info) {
void Log::MessageBuilder::AppendStringPart(const char* str, int len) {
if (pos_ + len > Log::kMessageBufferSize) {
len = Log::kMessageBufferSize - pos_;
- ASSERT(len >= 0);
+ DCHECK(len >= 0);
if (len == 0) return;
}
Vector<char> buf(log_->message_buffer_ + pos_,
Log::kMessageBufferSize - pos_);
StrNCpy(buf, str, len);
pos_ += len;
- ASSERT(pos_ <= Log::kMessageBufferSize);
+ DCHECK(pos_ <= Log::kMessageBufferSize);
}
void Log::MessageBuilder::WriteToLogFile() {
- ASSERT(pos_ <= Log::kMessageBufferSize);
+ DCHECK(pos_ <= Log::kMessageBufferSize);
// Assert that we do not already have a new line at the end.
- ASSERT(pos_ == 0 || log_->message_buffer_[pos_ - 1] != '\n');
+ DCHECK(pos_ == 0 || log_->message_buffer_[pos_ - 1] != '\n');
if (pos_ == Log::kMessageBufferSize) pos_--;
log_->message_buffer_[pos_++] = '\n';
const int written = log_->WriteToFile(log_->message_buffer_, pos_);
« no previous file with comments | « src/log-utils.h ('k') | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698