src/ia32/codegen-ia32.cc - Issue 430213004: Register all ExternalReferences in serializer code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 430213004: Register all ExternalReferences in serializer code. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Removed unused ExternalReferences, added few ASSERTs Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/codegen-ia32.cc

===================================================================

--- src/ia32/codegen-ia32.cc (revision 22763)

+++ src/ia32/codegen-ia32.cc (working copy)

@@ -928,6 +928,9 @@

ASSERT(!input.is(result));

ASSERT(!result.is(double_scratch));

ASSERT(!temp1.is(temp2));

+ // Serializer does not know how to encode references to math_exp_constants

+ // table. See ExternalReferenceTable::PopulateTable.

+ ASSERT(!masm->serializer_enabled());

ASSERT(ExternalReference::math_exp_constants(0).address() != NULL);

Label done;