Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 430213004: Register all ExternalReferences in serializer code. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Removed unused ExternalReferences, added few ASSERTs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/heap.h" 10 #include "src/heap.h"
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 void MathExpGenerator::EmitMathExp(MacroAssembler* masm, 921 void MathExpGenerator::EmitMathExp(MacroAssembler* masm,
922 XMMRegister input, 922 XMMRegister input,
923 XMMRegister result, 923 XMMRegister result,
924 XMMRegister double_scratch, 924 XMMRegister double_scratch,
925 Register temp1, 925 Register temp1,
926 Register temp2) { 926 Register temp2) {
927 ASSERT(!input.is(double_scratch)); 927 ASSERT(!input.is(double_scratch));
928 ASSERT(!input.is(result)); 928 ASSERT(!input.is(result));
929 ASSERT(!result.is(double_scratch)); 929 ASSERT(!result.is(double_scratch));
930 ASSERT(!temp1.is(temp2)); 930 ASSERT(!temp1.is(temp2));
931 // Serializer does not know how to encode references to math_exp_constants
932 // table. See ExternalReferenceTable::PopulateTable.
933 ASSERT(!masm->serializer_enabled());
931 ASSERT(ExternalReference::math_exp_constants(0).address() != NULL); 934 ASSERT(ExternalReference::math_exp_constants(0).address() != NULL);
932 935
933 Label done; 936 Label done;
934 937
935 __ movsd(double_scratch, ExpConstant(0)); 938 __ movsd(double_scratch, ExpConstant(0));
936 __ xorpd(result, result); 939 __ xorpd(result, result);
937 __ ucomisd(double_scratch, input); 940 __ ucomisd(double_scratch, input);
938 __ j(above_equal, &done); 941 __ j(above_equal, &done);
939 __ ucomisd(input, ExpConstant(1)); 942 __ ucomisd(input, ExpConstant(1));
940 __ movsd(result, ExpConstant(2)); 943 __ movsd(result, ExpConstant(2));
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 Code* stub = GetCodeAgeStub(isolate, age, parity); 1026 Code* stub = GetCodeAgeStub(isolate, age, parity);
1024 CodePatcher patcher(sequence, young_length); 1027 CodePatcher patcher(sequence, young_length);
1025 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32); 1028 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32);
1026 } 1029 }
1027 } 1030 }
1028 1031
1029 1032
1030 } } // namespace v8::internal 1033 } } // namespace v8::internal
1031 1034
1032 #endif // V8_TARGET_ARCH_IA32 1035 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/mips/codegen-mips.cc » ('j') | src/serialize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698