Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 430093003: Page action extension icons should handle tap events (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/page_action_image_view.h
diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.h b/chrome/browser/ui/views/location_bar/page_action_image_view.h
index 0d1a5e0f6923bb68144e9f8796788788c9aa6b53..6cd0e02b6134cc318815ceb631279d8e3521c9dc 100644
--- a/chrome/browser/ui/views/location_bar/page_action_image_view.h
+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.h
@@ -35,6 +35,8 @@ class PageActionImageView : public views::ImageView,
public views::ContextMenuController,
public ExtensionActionIconFactory::Observer {
public:
+ static const char kViewClassName[];
sky 2014/08/04 17:36:54 nit: there isn't a need to make this public unless
tdanderson 2014/08/05 15:32:32 Done.
+
PageActionImageView(LocationBarView* owner,
ExtensionAction* page_action,
Browser* browser);
@@ -49,10 +51,12 @@ class PageActionImageView : public views::ImageView,
}
// Overridden from views::View:
+ virtual const char* GetClassName() const OVERRIDE;
virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
+ virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
// Overridden from ExtensionContextMenuModel::Delegate
virtual void InspectPopup() OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698