cc: Heapify pointers instead of objects in eviction tile priority queue.

cc: Heapify pointers instead of objects in eviction tile priority queue.

This patch ensures that we heapify pointers instead of objects in
priority queue eviction.

Performance data:
Before:
tile_manager_eviction_tile_queue_construct:
2= 411875.46875 runs/s
10= 8762.1435546875 runs/s
50= 48.008880615234375 runs/s

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3337.1767578125 runs/s
2_32= 3041.9306640625 runs/s
2_64= 2513.700439453125 runs/s
2_128= 1940.756591796875 runs/s

After:
tile_manager_eviction_tile_queue_construct:
2= 391767.84375 runs/s (-5%)
10= 8705.869140625 runs/s (-2%)
50= 49.93892288208008 runs/s (+4%)

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3691.25146484375 runs/s (+10%)
2_32= 3666.619384765625 runs/s (+20%)
2_64= 3544.351318359375 runs/s (+41%)
2_128= 3341.751708984375 runs/s (+72%)

R=reveman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287846

[vmpstr, 2014-07-31 00:00:16]

PTAL. This is the same change as what https://codereview.chromium.org/431433005
does for raster iterators, so we can continue the review there and I'll make
similar changes here.

[vmpstr, 2014-08-05 20:17:00]

I've updated this to be similar to the raster tile priority queue (using
ScopedPtrVector). PTAL.

[reveman, 2014-08-06 01:37:42]

lgtm with nit

https://codereview.chromium.org/430053003/diff/20001/cc/resources/eviction_ti...
File cc/resources/eviction_tile_priority_queue.h (right):

https://codereview.chromium.org/430053003/diff/20001/cc/resources/eviction_ti...
cc/resources/eviction_tile_priority_queue.h:53:
ScopedPtrVector<PairedPictureLayerQueue> paired_queues_heap_;
nit: not sure it's necessary to add the "heap_" suffix. we usually avoid having
the type be part of the container member name. you're call but whatever you do,
keep RasterTilePriorityQueue consistent.

[vmpstr, 2014-08-06 15:54:19]

https://codereview.chromium.org/430053003/diff/20001/cc/resources/eviction_ti...
File cc/resources/eviction_tile_priority_queue.h (right):

https://codereview.chromium.org/430053003/diff/20001/cc/resources/eviction_ti...
cc/resources/eviction_tile_priority_queue.h:53:
ScopedPtrVector<PairedPictureLayerQueue> paired_queues_heap_;
On 2014/08/06 01:37:42, reveman wrote:
> nit: not sure it's necessary to add the "heap_" suffix. we usually avoid
having
> the type be part of the container member name. you're call but whatever you
do,
> keep RasterTilePriorityQueue consistent.

Done.

[vmpstr, 2014-08-06 15:54:23]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-08-06 15:55:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/430053003/40001

[commit-bot: I haz the power, 2014-08-06 20:37:34]

Change committed as 287846