Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 429993002: Subzero: Try to fix warnings and errors in the Windows build. (Closed)

Created:
6 years, 4 months ago by Jim Stichnoth
Modified:
6 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Try to fix warnings and errors in the Windows build. Quiet some unused-variable warnings when their only use is in an assert(). Forward-declare partial template specializations when the template method already has a default implementation, to avoid ODR violations and link errors. BUG= https://codereview.chromium.org/296053008/ R=wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6e99214

Patch Set 1 #

Total comments: 3

Patch Set 2 : Forward-declare latest set of emit() template specializations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/IceInstX8632.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
M src/IceInstX8632.cpp View 1 3 chunks +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jim Stichnoth
https://codereview.chromium.org/429993002/diff/1/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/429993002/diff/1/src/IceTargetLoweringX8632.cpp#newcode2739 src/IceTargetLoweringX8632.cpp:2739: Context.insert( sorry, this snuck in despite "make format-diff" :)
6 years, 4 months ago (2014-07-30 18:30:58 UTC) #1
wala
lgtm https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h File src/IceInstX8632.h (right): https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h#newcode1207 src/IceInstX8632.h:1207: template <> void InstX8632Subss::emit(const Cfg *Func) const; InstX8632Pblendvb, ...
6 years, 4 months ago (2014-07-30 19:51:00 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h File src/IceInstX8632.h (right): https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h#newcode1207 src/IceInstX8632.h:1207: template <> void InstX8632Subss::emit(const Cfg *Func) const; On 2014/07/30 ...
6 years, 4 months ago (2014-07-30 21:45:11 UTC) #3
Jim Stichnoth
6 years, 4 months ago (2014-07-30 21:45:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r6e99214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698