Subzero: Try to fix warnings and errors in the Windows build.

Subzero: Try to fix warnings and errors in the Windows build.

Quiet some unused-variable warnings when their only use is in an assert().

Forward-declare partial template specializations when the template method already has a default implementation, to avoid ODR violations and link errors.

BUG= https://codereview.chromium.org/296053008/
R=wala@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6e99214

[Jim Stichnoth, 2014-07-30 18:30:58]

https://codereview.chromium.org/429993002/diff/1/src/IceTargetLoweringX8632.cpp
File src/IceTargetLoweringX8632.cpp (right):

https://codereview.chromium.org/429993002/diff/1/src/IceTargetLoweringX8632.c...
src/IceTargetLoweringX8632.cpp:2739: Context.insert(
sorry, this snuck in despite "make format-diff" :)

[wala, 2014-07-30 19:51:00]

lgtm

https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h
File src/IceInstX8632.h (right):

https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h#newcode1207
src/IceInstX8632.h:1207: template <> void InstX8632Subss::emit(const Cfg *Func)
const;
InstX8632Pblendvb, InstX8632Blendvps, InstX8632Pinsr, and InstX8632Pextr are in
the latest version of the code and they also specialize emit().

[Jim Stichnoth, 2014-07-30 21:45:11]

https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h
File src/IceInstX8632.h (right):

https://codereview.chromium.org/429993002/diff/1/src/IceInstX8632.h#newcode1207
src/IceInstX8632.h:1207: template <> void InstX8632Subss::emit(const Cfg *Func)
const;
On 2014/07/30 19:51:00, wala wrote:
> InstX8632Pblendvb, InstX8632Blendvps, InstX8632Pinsr, and InstX8632Pextr are
in
> the latest version of the code and they also specialize emit().

Thanks.  There were a couple of class name changes as well.

[Jim Stichnoth, 2014-07-30 21:45:27]

Committed patchset #2 manually as r6e99214 (presubmit successful).