Remove GLInProcessContext::CreateContext()

webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
index 5ad1d777073235f7b45f35c9a66704923578d5cf..440898fbe28f7c546559b7f2251f1fdebaeb3ad1 100644
--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
@@ -147,11 +147,12 @@ bool WebGraphicsContext3DInProcessCommandBufferImpl::MaybeInitializeGL() {
     // will need to be lost either when the first context requesting the
     // discrete GPU is created, or the last one is destroyed.
     gfx::GpuPreference gpu_preference = gfx::PreferDiscreteGpu;
-
-    context_.reset(GLInProcessContext::CreateContext(
+    context_.reset(GLInProcessContext::Create(
+        scoped_refptr< ::gpu::InProcessCommandBuffer::Service>(),

[piman, 2014/07/31 02:42:29]

nit: NULL

[hj.r.chung, 2014/07/31 08:35:35]

Done.

+        NULL, /* surface */
         is_offscreen_,
-        window_,

[piman, 2014/07/31 02:42:29]

aren't there callers that pass a non-NULL window?
ui::InProcessContextFactory::CreateOutputSurface seems to be one.

[hj.r.chung, 2014/07/31 03:05:32]

yes, it's called with a non-NULL window but kNullAcceleratedWidget is used
instead of the passed window when initializing the context

[piman, 2014/07/31 03:41:11]

I don't follow.
ui::InProcessContextFactory::CreateOutputSurface calls
WebGraphicsContext3DInProcessCommandBufferImpl::CreateViewContext with a
non-NULL window. That calls
WebGraphicsContext3DInProcessCommandBufferImpl::WebGraphicsContext3DInProcessCommandBufferImpl
that keeps window into the field window_. When we get to MaybeInitializeGL,
window_ is non-NULL.

What am I missing?

Taken another way, some of the tests/demos that use InProcessContextFactory
display their results into the window. How else would it be possible, if not
passing the window to the GL context?

[hj.r.chung, 2014/07/31 08:35:35]

oops, I was looking at GLInProcessContext::Create instead of ::CreateContext.
Sorry about the confusion. adding 'window' back

         gfx::Size(1, 1),
+        NULL, /* share_context */
         share_resources_,
         attribs_,
         gpu_preference));