Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

Issue 429863002: Remove GLInProcessContext::CreateContext() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
index 5ad1d777073235f7b45f35c9a66704923578d5cf..440898fbe28f7c546559b7f2251f1fdebaeb3ad1 100644
--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
@@ -147,11 +147,12 @@ bool WebGraphicsContext3DInProcessCommandBufferImpl::MaybeInitializeGL() {
// will need to be lost either when the first context requesting the
// discrete GPU is created, or the last one is destroyed.
gfx::GpuPreference gpu_preference = gfx::PreferDiscreteGpu;
-
- context_.reset(GLInProcessContext::CreateContext(
+ context_.reset(GLInProcessContext::Create(
+ scoped_refptr< ::gpu::InProcessCommandBuffer::Service>(),
piman 2014/07/31 02:42:29 nit: NULL
hj.r.chung 2014/07/31 08:35:35 Done.
+ NULL, /* surface */
is_offscreen_,
- window_,
piman 2014/07/31 02:42:29 aren't there callers that pass a non-NULL window?
hj.r.chung 2014/07/31 03:05:32 yes, it's called with a non-NULL window but kNullA
piman 2014/07/31 03:41:11 I don't follow. ui::InProcessContextFactory::Creat
hj.r.chung 2014/07/31 08:35:35 oops, I was looking at GLInProcessContext::Create
gfx::Size(1, 1),
+ NULL, /* share_context */
share_resources_,
attribs_,
gpu_preference));

Powered by Google App Engine
This is Rietveld 408576698