Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: Source/core/core.gyp

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/core.gyp
diff --git a/Source/core/core.gyp b/Source/core/core.gyp
index 006821c5d3e15f8019efb875429b85ad86c469ae..700be1f2e9d9eb0151a346a5f81167d22edfb02e 100644
--- a/Source/core/core.gyp
+++ b/Source/core/core.gyp
@@ -281,6 +281,10 @@
# Generated from make_css_property_metadata.py
'<(blink_core_output_dir)/CSSPropertyMetadata.cpp',
+
+ # IDL dictionary impl files generated by IDL compiler
+ # FIXME: Add '<@(generated_core_dictionary_files)',
+ # See comment on core/core.gypi
],
'conditions': [
['OS=="win" and component=="shared_library"', {
@@ -743,6 +747,7 @@
'dependencies': [
'../config.gyp:config',
'webcore',
+ 'webcore_generated',
],
'defines': [
'BLINK_IMPLEMENTATION=1',
@@ -755,7 +760,10 @@
],
'sources': [
# Note: file list duplicated in GN build.
+ '<@(generated_core_testing_dictionary_files)',
'<@(webcore_testing_files)',
+ '<(bindings_core_v8_output_dir)/V8DictionaryTest.cpp',
+ '<(bindings_core_v8_output_dir)/V8DictionaryTest.h',
'<(bindings_core_v8_output_dir)/V8GarbageCollectedScriptWrappable.cpp',
'<(bindings_core_v8_output_dir)/V8GarbageCollectedScriptWrappable.h',
'<(bindings_core_v8_output_dir)/V8GCObservation.cpp',
@@ -780,6 +788,8 @@
'<(bindings_core_v8_output_dir)/V8LayerRectList.h',
'<(bindings_core_v8_output_dir)/V8RefCountedScriptWrappable.cpp',
'<(bindings_core_v8_output_dir)/V8RefCountedScriptWrappable.h',
+ '<(bindings_core_v8_output_dir)/V8TestingDictionary.cpp',
+ '<(bindings_core_v8_output_dir)/V8TestingDictionary.h',
],
'sources/': [
['exclude', 'testing/js'],

Powered by Google App Engine
This is Rietveld 408576698