Source/bindings/tests/results/V8TestObject.cpp - Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp

index 240cde609c6b6751b29ecfe244d3b3709a0e6cf1..7136457d312941bff78eb29da14d1494f2de23d7 100644

--- a/Source/bindings/tests/results/V8TestObject.cpp

+++ b/Source/bindings/tests/results/V8TestObject.cpp

@@ -8190,7 +8190,11 @@ static void overloadedMethodJ2Method(const v8::FunctionCallbackInfo<v8::Value>&

{

v8::TryCatch block;

V8RethrowTryCatchScope rethrow(block);

- TONATIVE_VOID_INTERNAL(testDictionaryArg, V8TestDictionary::toNative(info.GetIsolate(), info[0]));

+ if (!info[0]->IsUndefined()) {

+ TONATIVE_VOID_INTERNAL(testDictionaryArg, V8TestDictionary::toNative(info.GetIsolate(), info[0]));

+ } else {

+ testDictionaryArg = TestDictionary::create();

haraken 2014/08/26 04:00:40 Can you add a test case for this branch to a layou

bashi 2014/08/27 05:06:32 Done.

+ }

}

impl->overloadedMethodJ(testDictionaryArg);

}

« Source/bindings/scripts/idl_compiler.py ('K') | « Source/bindings/scripts/v8_methods.py ('k') | Source/core/BUILD.gn » ('j') | Source/core/testing/DictionaryTest.h » ('J')