Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 429803002: Revert of Remove WheelEvent.initWebKitWheelEvent() (Closed)

Created:
6 years, 4 months ago by alancutter (OOO until 2018)
Modified:
6 years, 4 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Revert of Remove WheelEvent.initWebKitWheelEvent() (https://codereview.chromium.org/425633002/) Reason for revert: This change broke the following browser_tests: NetInternalsTest.netInternalsTimelineViewDegenerate NetInternalsTest.netInternalsTimelineViewNoEvents NetInternalsTest.netInternalsTimelineViewZoomIn NetInternalsTest.netInternalsTimelineViewZoomOut http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/38303 Original issue's description: > Remove WheelEvent.initWebKitWheelEvent() > > Intent to Deprecate and Remove: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/h_GoezQ4MQ4/Q5abFkhA76sJ > > BUG=398422 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179183 TBR=tkent@chromium.org,philipj@opera.com NOTREECHECKS=true NOTRY=true BUG=398738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -16 lines) Patch
M LayoutTests/fast/events/wheelevent-in-scrolling-div.html View 2 chunks +3 lines, -12 lines 0 comments Download
M LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/resources/common-wheel-event.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/events/WheelEvent.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/events/WheelEvent.idl View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alancutter (OOO until 2018)
Created Revert of Remove WheelEvent.initWebKitWheelEvent()
6 years, 4 months ago (2014-07-30 05:07:11 UTC) #1
alancutter (OOO until 2018)
The CQ bit was unchecked by alancutter@chromium.org
6 years, 4 months ago (2014-07-30 05:07:16 UTC) #2
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 4 months ago (2014-07-30 05:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/429803002/1
6 years, 4 months ago (2014-07-30 05:08:53 UTC) #4
commit-bot: I haz the power
Change committed as 179198
6 years, 4 months ago (2014-07-30 05:09:29 UTC) #5
tkent
6 years, 4 months ago (2014-07-30 05:14:10 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698