chrome/browser/guest_view/extension_options/extension_options_guest.cc - Issue 429763002: Implement createfailed event for <extensionoptions>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 429763002: Implement createfailed event for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase onto CL 412093002 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/extension_options/extension_options_apitest.cc ('K') | « chrome/browser/guest_view/extension_options/extension_options_apitest.cc ('k') | chrome/renderer/resources/extensions/extension_options.js » ('j') | chrome/renderer/resources/extensions/extension_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

index 3c8c4f5666259bf073bae23f9ecff3a27a6843c4..efe6bdba5f28b37ca3d37da4db7210c3a2d0ec0c 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

@@ -69,7 +69,15 @@ void ExtensionOptionsGuest::CreateWebContents(

callback.Run(NULL);

return;

}

- DCHECK(extensions::Extension::IdIsValid(extension_id));

+ if (!extensions::Extension::IdIsValid(extension_id)) {

+ callback.Run(NULL);

+ return;

+ }

+ if (extension_id != embedder_extension_id) {

+ callback.Run(NULL);

+ return;

+ }

GURL extension_url =

extensions::Extension::GetBaseURLFromExtensionId(extension_id);