Implement createfailed event for <extensionoptions>

chrome/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 47 matching lines @@
 }
 
 void ExtensionOptionsGuest::CreateWebContents(
     const std::string& embedder_extension_id,
     int embedder_render_process_id,
     const base::DictionaryValue& create_params,
     const WebContentsCreatedCallback& callback) {
   // Get the extension's base URL.
   std::string extension_id;
   create_params.GetString(extensionoptions::kExtensionId, &extension_id);
   if (extension_id.empty()) {

[not at google - send to devlin, 2014/07/30 17:33:10]

this condition is actually covered by the one on line 72.

[ericzeng, 2014/08/01 17:13:26]

Removed.

     callback.Run(NULL);
     return;
   }
-  DCHECK(extensions::Extension::IdIsValid(extension_id));
+  if (!extensions::Extension::IdIsValid(extension_id)) {
+    callback.Run(NULL);
+    return;
+  }
+
+  if (extension_id != embedder_extension_id) {
+    callback.Run(NULL);
+    return;
+  }
 
   GURL extension_url =
       extensions::Extension::GetBaseURLFromExtensionId(extension_id);
   if (!extension_url.is_valid()) {
     callback.Run(NULL);
     return;
   }
 
   // Get the options page URL for later use.
   extensions::ExtensionRegistry* registry =
@@ skipping 48 matching lines @@
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ExtensionOptionsGuest::OnRequest(
     const ExtensionHostMsg_Request_Params& params) {
   extension_function_dispatcher_->Dispatch(
       params, guest_web_contents()->GetRenderViewHost());
 }