Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4864)

Unified Diff: chrome/test/chromedriver/performance_logger_unittest.cc

Issue 429693003: [ChromeDriver] Implementing PerfLoggingPrefs for perf log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing memory leak Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger_unittest.cc
diff --git a/chrome/test/chromedriver/performance_logger_unittest.cc b/chrome/test/chromedriver/performance_logger_unittest.cc
index cab92c85b9902fdbb8c12a86b29859923b0acb89..2d6c7488a80d1259da21c540fcae66bfd4f5921e 100644
--- a/chrome/test/chromedriver/performance_logger_unittest.cc
+++ b/chrome/test/chromedriver/performance_logger_unittest.cc
@@ -188,3 +188,22 @@ TEST(PerformanceLogger, TwoWebViews) {
ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");
ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");
}
+
+TEST(PerformanceLogger, PerfLoggingPrefs) {
+ FakeDevToolsClient client("webview-1");
+ FakeLog log;
+ PerfLoggingPrefs prefs;
+ ASSERT_EQ(PerfLoggingPrefs::InspectorDomainStatus::kDefaultEnabled,
+ prefs.network);
+ prefs.network = PerfLoggingPrefs::InspectorDomainStatus::kExplicitlyDisabled;
+ // Trace categories should be ignored until tracing support is implemented.
+ prefs.trace_categories = "benchmark,webkit.console";
+ PerformanceLogger logger(&log, prefs);
+
+ client.AddListener(&logger);
+ logger.OnConnected(&client);
+ EXPECT_EQ("Page.enable", client.PopSentCommand());
+ // Trace categories ignored, so Timeline shouldn't be implicitly disabled.
+ EXPECT_EQ("Timeline.start", client.PopSentCommand());
+ EXPECT_TRUE(client.PopSentCommand().empty());
+}
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698