Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: chrome/test/chromedriver/performance_logger_unittest.cc

Issue 429693003: [ChromeDriver] Implementing PerfLoggingPrefs for perf log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing memory leak Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/performance_logger.h" 5 #include "chrome/test/chromedriver/performance_logger.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/memory/scoped_vector.h" 10 #include "base/memory/scoped_vector.h"
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 ExpectEnableDomains(client1); 181 ExpectEnableDomains(client1);
182 EXPECT_TRUE(client2.PopSentCommand().empty()); 182 EXPECT_TRUE(client2.PopSentCommand().empty());
183 183
184 ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code()); 184 ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code());
185 ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code()); 185 ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code());
186 186
187 ASSERT_EQ(2u, log.GetEntries().size()); 187 ASSERT_EQ(2u, log.GetEntries().size());
188 ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1"); 188 ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");
189 ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2"); 189 ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");
190 } 190 }
191
192 TEST(PerformanceLogger, PerfLoggingPrefs) {
193 FakeDevToolsClient client("webview-1");
194 FakeLog log;
195 PerfLoggingPrefs prefs;
196 ASSERT_EQ(PerfLoggingPrefs::InspectorDomainStatus::kDefaultEnabled,
197 prefs.network);
198 prefs.network = PerfLoggingPrefs::InspectorDomainStatus::kExplicitlyDisabled;
199 // Trace categories should be ignored until tracing support is implemented.
200 prefs.trace_categories = "benchmark,webkit.console";
201 PerformanceLogger logger(&log, prefs);
202
203 client.AddListener(&logger);
204 logger.OnConnected(&client);
205 EXPECT_EQ("Page.enable", client.PopSentCommand());
206 // Trace categories ignored, so Timeline shouldn't be implicitly disabled.
207 EXPECT_EQ("Timeline.start", client.PopSentCommand());
208 EXPECT_TRUE(client.PopSentCommand().empty());
209 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698